Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF add item file for cap/measured_value/substance #7146

Merged
merged 2 commits into from Sep 4, 2023

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Aug 4, 2023

See #7121

@SwoopX
Copy link
Collaborator

SwoopX commented Aug 5, 2023

Wasn't that item supposed to be called cap/measured_value/substance?

#7121 (comment)

@Smanar
Copy link
Collaborator Author

Smanar commented Aug 6, 2023

IDK, it make no difference for me.
I have started the previous PR with "dimension", but I can change it if you prefer ?

@Smanar Smanar changed the title DDF add item file for cap/measured_value/dimension DDF add item file for cap/measured_value/substance Aug 7, 2023
@Smanar
Copy link
Collaborator Author

Smanar commented Aug 7, 2023

Updated for substance

@manup
Copy link
Member

manup commented Aug 11, 2023

That was my question in another PRs comment. I agree that "dimension" is a bit meh, but keep in mind that measured value is not all about substances, e.g. °C for temperature isn't a substance.

I'd prefer a generic word here, otherwise it feels again like the Window Covering devices under a /lights thing to me.

Ideas?

@ebaauw
Copy link
Collaborator

ebaauw commented Aug 11, 2023

The physics term for what you're measuring: quantity (grootheid in Dutch; Größe in German, quantité in French).

As opposed to how you express a measured value: unit (eenheid in Dutch, Einheit in German, unité in French).

@manup
Copy link
Member

manup commented Aug 11, 2023

quantity is perfect from what I read on Wikipedia, Dutch version is pretty cool too :)

https://en.wikipedia.org/wiki/List_of_physical_quantities

Everybody ok with cap/measured_value/quantity ?

@SwoopX
Copy link
Collaborator

SwoopX commented Aug 12, 2023

No? You might have totally lost me on this one, but were discussing the "what", not the "how much"?

@ebaauw
Copy link
Collaborator

ebaauw commented Aug 12, 2023

In physics, the “what” is called “quantity”, see the Wiki that Manu linked.

@SwoopX
Copy link
Collaborator

SwoopX commented Aug 12, 2023

Sodium is the name a chemical element, it is what will serve as an example here. Sodium has SI defined base quantities, e.g. a mass or an amount of substance.
I assume we do all agree that we already use the base quantity amount of substance aka measured value, but we want to communicate measured value of what or which chemical element or which substance.

Haven't seen any chemical element been defined as quantity, but maybe I've overlooked it.

@ebaauw
Copy link
Collaborator

ebaauw commented Aug 13, 2023

Haven't seen any chemical element been defined as quantity

Neither have I. Nor have I seen any sensors that measure a chemical elements. Sensors measure quantities like the density or level of that element. CO2 is a chemical element; CO2 level is a quantity, typically expressed in ppb; CO2 density would be another quantity, typically expressed in um/m3.

I assume we do all agree that we already use the base quantity amount of substance

The amount of CO2 would be yet another quantity, typically expressed in mol. I haven’t seen any sensors for that.

I suppose we could split quantity (what) vs substance (of what) into separate attributes. That would also help with air temperature vs water temperature vs device temperature (although it might be a stretch to see a device as “substance”), or mains voltage vs battery voltage.

@SwoopX
Copy link
Collaborator

SwoopX commented Aug 13, 2023

I guess we're pretty close to each other

I suppose we could split quantity (what) vs substance (of what) into separate attributes

This is what I'm arguing, and only the of what part. We're here with the Concentration Measurement cluster only, which lists something like 32 chemical elements or organic/chemical compounds (primarily). Zigbee standard calls the of what "substance measured", the suggestion in PR #7121 was to call it "dimension", which I dislike and do not feel appropriate. Even the SI base quantity "amount of substance" references substance, so I'd suggest we just call it like that

grafik

For anything else related to quantities (what), be it to call it generically "quantity" or name whatever as a base quantity or anything even more specific, you most likely get an instant full ACK from me 🙂

@BabaIsYou
Copy link
Contributor

BabaIsYou commented Aug 17, 2023

From my point of view, quantity is the amount of something and not the something by itself (/measured_value/substance) expressed in a certain unit of measurement (measured_value/unit) whose value is measured_value.

@manup
Copy link
Member

manup commented Aug 28, 2023

I'm still a bit lost here. So from my understanding if we go with cap/measured_value/substance it must be restricted to actual substances. For non substances like "temperature" this item must not be added, we can later on think of adding additional cap/measured_value/quantity if needed if the sensor "type" isn't enough (not a high priority currently but I'd like to have something like that later on for the UI part).

Would that be ok?

@manup manup added this to the v2.23.1-beta milestone Aug 29, 2023
@BabaIsYou
Copy link
Contributor

Sorry if my previous post may have added to the confusion. I reviewed it in order to remove all that was humorous or not factual which may not go well all the time... ;-)

@manup manup merged commit 14f1825 into dresden-elektronik:master Sep 4, 2023
1 check failed
@Smanar Smanar deleted the airtruc branch April 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants