Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDF for Aqara T1 Temperature and Humidity Sensor WSDCGQ12LM #7241

Merged
merged 2 commits into from Sep 25, 2023

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Sep 16, 2023

Adds initial support for the device. Verification of the special reporting is pending, this is currently an educated guess.

@SwoopX SwoopX added this to the v2.23.1 milestone Sep 16, 2023
@SwoopX SwoopX linked an issue Sep 16, 2023 that may be closed by this pull request
@SwoopX SwoopX modified the milestones: v2.23.1, v2.24.1-beta Sep 17, 2023
@manup
Copy link
Member

manup commented Sep 24, 2023

There are also additions of "mf": "0x115F" in other devices parse functions, could you test that these work?
Perhaps these should be separate "Fix ... " PRs so they are also listed in the changelog :)

The new xiaomi_wsdcgq12lm_t1_temp_hum_sensor.json seems to contain invalid JSON?

Error: Parse error on line 94:
...mperature",        },        {       
----------------------^
Expecting 'STRING', got '}'

@SwoopX
Copy link
Collaborator Author

SwoopX commented Sep 24, 2023

The new xiaomi_wsdcgq12lm_t1_temp_hum_sensor.json seems to contain invalid JSON?

Error: Parse error on line 94:
...mperature",        },        {       
----------------------^
Expecting 'STRING', got '}'

Ah, nice catch. Thought, the validator would notify on this one as well 🙂

There are also additions of "mf": "0x115F" in other devices parse functions, could you test that these work?

Well, I guess this is more of a documentary addition rather than necessary. The Xiaomi parse function is currently not explicitly requesting the correct mfc.
As I recall, all those occurrances came from me anyway and were based on some sniffing, so I'm pretty confident it is all working alright (for the devices I own, where this doesn't count to).

@manup
Copy link
Member

manup commented Sep 25, 2023

Ah, nice catch. Thought, the validator would notify on this one as well 🙂

It did :) output is a bit noisy due the errors not related to this DDF, but there was a inline box complaining about JSON.

There are also additions of "mf": "0x115F" in other devices parse functions, could you test that these work?

Well, I guess this is more of a documentary addition rather than necessary. The Xiaomi parse function is currently not explicitly requesting the correct mfc. As I recall, all those occurrances came from me anyway and were based on some sniffing, so I'm pretty confident it is all working alright (for the devices I own, where this doesn't count to).

Ah ok, well then lets give it a try

@manup manup merged commit 05c9e7a into dresden-elektronik:master Sep 25, 2023
1 check failed
@SwoopX SwoopX deleted the lumi.sensor_ht.agl02 branch January 5, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AQARA Temperature and Humidity Sensor T1
2 participants