Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF for IKEA TRADFRI wireless dimmer #7242

Merged
merged 1 commit into from Sep 24, 2023

Conversation

ebaauw
Copy link
Collaborator

@ebaauw ebaauw commented Sep 16, 2023

New DDF, in line with DDFs for other IKEA controllers.

This is the cursed, old, round wireless dimmer. It insists on sending multiple groupcasts from Level Control when turning it, completely flooding the Zigbee network. It won't honour any unicast binding for Level Control (even though it does for Power Configuration). When you delete the group binding, it continues to send groupcasts to group 0x0000.

I think the device should have been exposed with only a ZHARelativeRotary resource, since it only supports turning and has no buttons. This might be challenging to do in JSON and Javascript, as it sends three different commands, Move, Move (with On/Off), and Move to Level (with On/Off), that need to be considered for rotary events. For now it's still exposed as ZHASwitch, as I doubt the change would be worth the effort, since the device is hardly usable anyways. The main benefit of this DDF is to be able to get rid of whitelisting IKEA devices in the C++ code.

{
  "config": {
    "alert": "none",
    "battery": 87,
    "group": "4",
    "on": true,
    "reachable": true
  },
  "ep": 1,
  "etag": "39cccb7e96bc5b2a615b02d8b1686862",
  "lastannounced": "2023-09-16T20:42:15Z",
  "lastseen": "2023-09-16T21:11Z",
  "manufacturername": "IKEA of Sweden",
  "mode": 1,
  "modelid": "TRADFRI wireless dimmer",
  "name": "Switch 128",
  "productid": "E1724",
  "state": {
    "buttonevent": 1003,
    "lastupdated": "2023-09-16T21:11:46.062"
  },
  "swversion": "2.3.028",
  "type": "ZHASwitch",
  "uniqueid": "00:0b:57:ff:fe:88:b9:a0-01-1000"
}

@ebaauw ebaauw added Device Request Device Improvement Additional tag to attach to a existing issue. labels Sep 16, 2023
@ebaauw ebaauw added this to the v2.24.1-beta milestone Sep 16, 2023
@ebaauw ebaauw requested a review from manup September 16, 2023 21:14
@manup
Copy link
Member

manup commented Sep 24, 2023

The main benefit of this DDF is to be able to get rid of whitelisting IKEA devices in the C++ code.

This was also my thought after a quick check in C++ code :)

I'd be surprised if the device is actually used in setups. So I guess merging this PR and removing the C++ part soon should be fine.

@manup manup merged commit 006f4c9 into dresden-elektronik:master Sep 24, 2023
1 check failed
@ebaauw ebaauw deleted the wireless-dimmer branch September 24, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device Improvement Additional tag to attach to a existing issue. Device Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants