Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF for Elko Smart ZB Thermostat 16 A (#7225) #7270

Merged

Conversation

gladhorn
Copy link
Contributor

@gladhorn gladhorn commented Sep 30, 2023

There is some general information here:
https://proff.elko.no/elko-smart/ELKO%20-%20Smart%20ZB%20Thermostat%2016%20A_Device%20User%20Guide/English/ELKO%20-%20Smart%20ZB%20Thermostat%2016%20A_Device%20User%20Guide_0000930613.html

Thermostat with support for two temperature sensors and some metering. There is also the option of setting a schedule, which is ignored for now. With this DDF, temperature(s) are read, setting temperature and reading heating state works.

Done-with: Smanar

@Mimiix
Copy link
Collaborator

Mimiix commented Sep 30, 2023

Hi

I removed the email adress of Smanar for privacy purposes. Please refrain from posting personal details in th future.

Thank you.

Kind regards,
Dennis

Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minors to remove unnecessary lines.

@gladhorn
Copy link
Contributor Author

gladhorn commented Oct 2, 2023

Hi

I removed the email adress of Smanar for privacy purposes. Please refrain from posting personal details in th future.

Thank you.

Kind regards, Dennis

Sure thing. The email address is a lot in the git history, so I cannot see how this protects it from anything, but I don't mind either way. I certainly didn't mean to share anything private or go against any rules here, the intention was to give credit.

There is some general information here:
https://proff.elko.no/elko-smart/ELKO%20-%20Smart%20ZB%20Thermostat%2016%20A_Device%20User%20Guide/English/ELKO%20-%20Smart%20ZB%20Thermostat%2016%20A_Device%20User%20Guide_0000930613.html

Thermostat with support for two temperature sensors and some metering.
There is also the option of setting a schedule, which is ignored for now.
With this DDF, temperature(s) are read, setting temperature and reading
heating state works.

Done-with: Smanar <aurelien.pra@laposte.net>
@gladhorn gladhorn force-pushed the gladhorn/elko_thermostat_16_a branch from c8dee44 to aeb65f4 Compare October 3, 2023 10:43
@gladhorn gladhorn requested a review from SwoopX October 4, 2023 08:30
@gladhorn
Copy link
Contributor Author

Anything else needed to get this in? @Smanar maybe?

@Smanar
Copy link
Collaborator

Smanar commented Oct 14, 2023

No, for me it's fine.
You have corrected all @SwoopX suggestions and your DDF don't make the validator crying, so for me just need to wait, don't worry.

@manup manup added this to the v2.25.0-beta milestone Nov 29, 2023
@manup manup merged commit d6563c6 into dresden-elektronik:master Nov 29, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants