New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DDF for MHCOZY ZG-005-RF #7310
Conversation
For me not a good idea to change model id and manufacture name. It's alredy a problem for lidl with user not able to reconize their own device (and it's not possible for devs too if this one don't have access to the GUI). And we had some issue with that in c++ core with device that fail some checks with value "randomly patched" during core evolution, it's a field too critic to be patched, just for estetic reasons. And can have tommorow the same device but on another brand called ZG-008-XY Good question about "config" for "light", I have this problem too, and I m not sure creating a ZHASensor is the better idea. But with this way you can put all the config on the "sensor" (and only 1 created), so not a problem for that
And about
Never make assumptions with Tuya ^^ |
Don't overwrite _Manufacturer Name_ nor _Model Identifier_. Expose non-Tuya model as `productid`.
Now basing
|
Nice, on my side I prefer ^^, this solution is perfect for me. |
I have tested it, I'm not sure if it is related to deconz-rest or is it a HW issue, but the device is time to time not reachable, it keeps the last state however. It comes back online again after a while however. |
See #7309.
Initial support is quite straightforward, see resources below.
I want to expose the button mode (values:
toggle
,state
,momentary
) and, if we can reverse engineer it, the device mode (values:self-locking
,interlock
;jog
), but I'm a bit lost in the variousconfig
attributes:clickmode
vsdevicemode
vsmode
. Neither are currently supported forlights
attributes, and I don't think the API checks for valid values when PUTting these for/sensors
resources. I think we'd need correspondingcapabilities
attributes to list the possible values.Also these modes are for all endpoints. In
/devices
I would expose these on the main device. Not sure whether to expose these on all/lights
resources, or only on the first.I'm not sure if we already have a standard how we name DDFs for devices using the Tuya convention. I've seen, what I assume is the same device on Amazon an AliExpress, which different (commercial) manufacturer name and model identifier. I don't know if these use the same Manufacturer Name and Model Identifier values.