Repository navigation
DDF for Bosch Smoke Alarm II (#9) - #7354
Merged
Merged
Conversation
* Create bsd-2-smoke-alarm.js * Rename bsd-2-smoke-alarm.js to bsd-2-smoke-alarm.json
Contributor
Author
|
Hu? Validation error for DDF code provided by the deCONZ GUI DDF editor? |
SwoopX
requested changes
Nov 13, 2023
Collaborator
|
Really good DDF. One question though: does the device respond to arbitrary read requests without waking it up? |
Contributor
Author
The device responds to read requests, e.g. to read a cluster via GUI. It does so at any time as far as I noticed. |
Member
|
@SwoopX PR looks good to me, ready to merge? |
SwoopX
approved these changes
Nov 16, 2023
Collaborator
|
@manup Yeah, all looking good. You could remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create bsd-2-smoke-alarm.js
Rename bsd-2-smoke-alarm.js to bsd-2-smoke-alarm.json