Skip to content

DDF for innr SP 240 - #7486

Merged
manup merged 4 commits into
dresden-elektronik:masterfrom
jmue:sp_240
Dec 27, 2023
Merged

DDF for innr SP 240#7486
manup merged 4 commits into
dresden-elektronik:masterfrom
jmue:sp_240

Conversation

@jmue

@jmue jmue commented Dec 23, 2023

Copy link
Copy Markdown
Contributor

add DDF for innr SP 240 plug with consumption an power sensor

Signed-off-by: Jens Müller <tschenser@gmx.de>
@jmue jmue changed the title add ddf for innr sp240 DDF for innr SP 240 Dec 23, 2023

@ebaauw ebaauw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, a new innr plug with power monitoring. And, according to its specs, it supports up to 16A. Ordered a couple to try them out, and see if they'll handle my washing machine and dryer.

As for the DDF (somehow, I cannot enter comments in-line):

  • The refresh interval for state/on should be 360: the periodic reporting interval plus 60s;
  • Doesn't the plug report voltage and current (amperage) on 0x0B04. The SP120 did;
  • It doesn't make sense to create a binding and attribute reporting for Level Control (0x0008), since Current Level isn't reported through the API. Typically plugs only include Level Control to be able to react to Move to Level (with On/Off); they's don't report Current Level, other than 0 or 254, corresponding to On/Off.
  • The SP120 also supported attribute reporting on 0x0B04 and 0x0702.

@jmue

jmue commented Dec 23, 2023

Copy link
Copy Markdown
Contributor Author

Fixed, ​could you please explain why I should add 60 seconds?

@jmue

jmue commented Dec 23, 2023

Copy link
Copy Markdown
Contributor Author

I'm new to DDF, attributes and stuff. Could you point me in the right direction as to what should be added, what should be changed and why it is necessary.
Thank you.

Signed-off-by: Jens Müller <tschenser@gmx.de>
@jmue

jmue commented Dec 23, 2023

Copy link
Copy Markdown
Contributor Author

Yes, the plug reports current, power, voltage and consumption.

Signed-off-by: Jens Müller <tschenser@gmx.de>
@ebaauw

ebaauw commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

See the DDF for the SP 120 as example; I would expect the SP 240 to be similar.

Fixed, ​could you please explain why I should add 60 seconds?

As safety margin. Ideally, the plug reports its attributes and deCONZ won’t need to poll the device. Polling is configured only as fallback, in case the reporting fails.

@Smanar Smanar mentioned this pull request Dec 23, 2023
1 task
@SwoopX SwoopX linked an issue Dec 23, 2023 that may be closed by this pull request
1 task
@ebaauw
ebaauw self-requested a review December 23, 2023 21:52

@ebaauw ebaauw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should do it.

@SwoopX SwoopX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Could you please remove the path stanza (line 8) and change any refresh.interval value to 360 where it currently is set to 300? Thanks!

Signed-off-by: Jens Müller <tschenser@gmx.de>
@manup manup added this to the v2.25.1 milestone Dec 27, 2023
@manup
manup merged commit b298bb0 into dresden-elektronik:master Dec 27, 2023
@jmue
jmue deleted the sp_240 branch January 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

innr SP 240 smart plug

4 participants