Optimize idle timer and legacy device polling #7574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This part of the code is a mess and grown over time. The PR tries to: - Break up looping over all sensors and lights by only processing up to 5 from each per idle timer call. - Fetch modelid/manufacturer name from parent Device instead of looping over sibling lights and sensors. - Control pacing of legacy poll manager via DDF device tick to not schedule things in parallel. Over time the legacy idle timer and poll manager code needs to go, it will take some iterations to do this and even break legacy devices in the process, which needs to be converted to DDF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the code is a mess and grown over time.
The PR tries to:
Over time the legacy idle timer and poll manager code needs to go, it will take some iterations to do this and even break legacy devices in the process, which needs to be converted to DDF.