Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF for IKEA ASKVADER on/off switch #7592

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

mattreim
Copy link
Contributor

IKEA ASKVADER on/off switch:

askvader_on_off_switch

Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR. Just some minors to address as far as I can tell.

However, as we do not have a dedicated device support request for this particular device, I need to judge on what I see here. No guarantee anything is missed but trusting it's complete 🙂

devices/ikea/askvader_on_off_switch Outdated Show resolved Hide resolved
@mattreim
Copy link
Contributor Author

I hope it's right. thanks for the help.

@mattreim
Copy link
Contributor Author

Should I repair the Tradfri control outlet?

@SwoopX
Copy link
Collaborator

SwoopX commented Feb 12, 2024

Should I repair the Tradfri control outlet?

I'd probably apply the same reporting config also for this device. Simple deconz restart should be sufficient then.

@mattreim
Copy link
Contributor Author

Sollte ich die Tradfri-Steuersteckdose reparieren?

Ich würde wahrscheinlich dieselbe Berichtskonfiguration auch für dieses Gerät anwenden. Dann sollte ein einfacher Deconz-Neustart ausreichen.

I mean this: https://github.com/dresden-elektronik/deconz-rest-plugin/blob/master/devices/ikea/tradfri_control_outlet.json

@SwoopX
Copy link
Collaborator

SwoopX commented Feb 12, 2024

Sollte ich die Tradfri-Steuersteckdose reparieren?

Ich würde wahrscheinlich dieselbe Berichtskonfiguration auch für dieses Gerät anwenden. Dann sollte ein einfacher Deconz-Neustart ausreichen.

I mean this: https://github.com/dresden-elektronik/deconz-rest-plugin/blob/master/devices/ikea/tradfri_control_outlet.json

Yeah, I know which device you meant, but maybe I did not (correctly) get what you intended to do?

@mattreim
Copy link
Contributor Author

mattreim commented Feb 12, 2024

From:
From

To:
To

@SwoopX
Copy link
Collaborator

SwoopX commented Feb 13, 2024

Ah, you want to change the other DDF accordingly 🙂

Well, if you have the device and can test it, feel free. But watch out the duplicate cluster entry you have accidentally in there.

@mattreim
Copy link
Contributor Author

Ok

@manup manup added this to the v2.27.0-beta milestone Feb 15, 2024
@manup manup merged commit 9e648cb into dresden-elektronik:master Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants