Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary read requests for some Xiaomi devices #7602

Merged
merged 1 commit into from Feb 15, 2024

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Feb 11, 2024

Some read functions were without refresh.interval, potentially resulting in excessive unwanted read requests.

@SwoopX SwoopX added the Fix label Feb 11, 2024
@mattreim
Copy link
Contributor

Is it the same with "xiaomi_ssm-u01_t1_switch"?

@SwoopX
Copy link
Collaborator Author

SwoopX commented Feb 11, 2024

Is it the same with "xiaomi_ssm-u01_t1_switch"?

What do you mean?

@mattreim
Copy link
Contributor

ssm-u01_t1_clickmode

ssm-u01_t1_devicemode

There seem to be quite a few queries.

@SwoopX
Copy link
Collaborator Author

SwoopX commented Feb 11, 2024

That is perfectly fine. An interval is defined here.

@mattreim
Copy link
Contributor

Ok

@manup manup modified the milestones: v2.27.0-beta, v2.26.1-beta Feb 12, 2024
@manup manup merged commit 77fa571 into dresden-elektronik:master Feb 15, 2024
1 check passed
@SwoopX SwoopX deleted the fix_refresh_interval branch March 28, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants