Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative value for sensitivity for Aqara/Xiaomi vibration sensor #7618

Merged
merged 2 commits into from Feb 20, 2024

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Feb 17, 2024

Untested, I haven't the device, but I don't thing It can cause issues.

{
  "config": {
    "battery": 100,
    "duration": 65,
    "on": true,
    "reachable": true,
    "sensitivity": -8,
    "sensitivitymax": 2,
    "temperature": 2600
  },
  "ep": 1,
  "etag": "241c373ed0ac1b2e46c84b5985520189",
  "lastannounced": null,
  "lastseen": "2024-02-17T16:26Z",
  "manufacturername": "LUMI",
  "modelid": "lumi.vibration.aq1",
  "name": "Vibration Chambre Devant",
  "state": {
    "lastupdated": "2024-02-17T16:26:25.934",
    "orientation": [
      -1,
      79,
      11
    ],
    "tiltangle": 6,
    "vibration": false,
    "vibrationstrength": 4
  },
  "swversion": "0.0.0_0008",
  "type": "ZHAVibration",
}

If user have set a value > 2 for sensitivity on the device before the DDF was used (autorised value could go up to 21), this one was stored on the device. And even it don't have impact, it can make a negative value as return.

@manup manup added the Fix label Feb 20, 2024
@manup manup added this to the v2.26.1-beta milestone Feb 20, 2024
@manup manup changed the title FIX, prevent negative value for sensitivity for Aqara/Xiaomi vibration sensor Fix negative value for sensitivity for Aqara/Xiaomi vibration sensor Feb 20, 2024
devices/xiaomi/lumi_vibration_aq1.json Outdated Show resolved Hide resolved
@manup manup merged commit 6edecc5 into dresden-elektronik:master Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants