Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX, prevent some powered tuya Thermostat to freeze zigbee network. #7655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Mar 8, 2024

Concern devices "_TZE200_ztvwu4nk", "_TZE204_5toc8efa", "_TZE200_5toc8efa", "_TZE200_ye5jkfsb", "_TZE204_aoclfnxz", "_TZE200_u9bfwha0".

This device is powered, so realy talkative and it can send the valve position realy fastly, even the state doesn't change.

16:28:28:757 TY_DATA_REPORT: seq 465, dpid: 0x24, type: 0x04, length: 1, val: 1
16:28:28:759 TY_DATA_REPORT: seq 465, dpid: 0x24, type: 0x04, length: 1, val: 1
16:28:28:761 Websocket 10.0.0.1:45396 send message: {"e":"changed","id":"159","r":"sensors","state":{"lastupdated":"2024-02-18T15:28:28.759","temperature":2100,"valve":0},"t":"event","uniqueid":"a4:c1:38:53:57:a4:3e:2f-01-ef00"} (ret = 1696907060)
16:28:28:924 TY_DATA_REPORT: seq 465, dpid: 0x24, type: 0x04, length: 1, val: 1
16:28:28:926 TY_DATA_REPORT: seq 465, dpid: 0x24, type: 0x04, length: 1, val: 1
16:28:28:928 TY_DATA_REPORT: seq 465, dpid: 0x24, type: 0x04, length: 1, val: 1
16:28:28:929 TY_DATA_REPORT: seq 465, dpid: 0x24, type: 0x04, length: 1, val: 1
16:28:28:931 TY_DATA_REPORT: seq 465, dpid: 0x24, type: 0x04, length: 1, val: 1
16:28:28:933 Websocket 10.0.0.1:45396 send message: {"e":"changed","id":"159","r":"sensors","state":{"lastupdated":"2024-02-18T15:28:28.931","temperature":2100,"valve":0},"t":"event","uniqueid":"a4:c1:38:53:57:a4:3e:2f-01-ef00"} (ret = 1696907060)

And deconz make a new websocket notification every time, even the state not change, and third app probably do same after. The result is the whole zigbee network is freezed (CPU usage is normal).

We have tried

        {
          "name": "state/valve",
          "parse": {"fn": "tuya", "dpid": 36, "eval": "if R.item('state/valve').val != Attr.val {Item.val = Attr.val;}"},
          "read": {"fn": "none"}
        }

To prevent spam, it's better, but not a sucess.

And ofc not way to set a report delay on tuya cluster.

So for the moment, better to remove it.

@Smanar Smanar changed the title FIX, prevent a tuya TRV to freeze zigbee network. FIX, prevent some powered tuya Thermostat to freeze zigbee network. Mar 8, 2024
@manup
Copy link
Member

manup commented Mar 16, 2024

Interesting, looks like the sequence number is all the same, do we need de-duplication here to process only on different sequence numbers?

@Smanar
Copy link
Collaborator Author

Smanar commented Mar 16, 2024

do we need de-duplication here to process only on different sequence numbers?

I m not sure to understand what you mean, but yes, we can ignore all other sequence, and use only the first one. It's device spamming, and I think it's from the device, not a missing answer from deconz, as all other dpid are working fine.

Not the first time I see this kind of spam on logs with tuya device.

@manup manup added the Fix label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants