Move REST API common code to rest_api.cpp/h #7674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
de_web_plugin_private.hheader is currently a sink hole for all kinds of unrelated code.The PR moves parts which are only needed by REST API handling code into a new module
rest_api.h.REST API handling code doesn't need to know and depend on all what is in
de_web_plugin_private.h. Headers likemath.handtuya.hwhich where also included are now only included in.cppfiles which need them. Main goal here is to reduce coupling and also speed up compilation a bit as side effect.