Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF for Bosch Light/shutter control II #7683

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Mar 28, 2024

Interesting device. Making an educated guess here, especially on the switch resource and the button map. Would be great if it could be tested upfront.

Closes #7661

@SwoopX SwoopX added this to the v2.27.0-beta milestone Mar 28, 2024
@SwoopX SwoopX marked this pull request as ready for review March 28, 2024 21:55
@Smanar
Copy link
Collaborator

Smanar commented Mar 29, 2024

Hello, you are sure for

        <attribute id="0x0000" name="Device mode" type="enum8" mfcode="0x1209" access="rw" required="m"></attribute>
        <attribute id="0x0001" name="Switch type" type="enum8" mfcode="0x1209" access="rw" required="m"></attribute>

According that I have see on the link gived by the user, the attribute 0x0000 is the device mode yes, but for me it's more something like

        <attribute id="0x0000" type="enum8" name="Device mode" access="rw" required="o" mfcode="0x1209">
             <value name="undefined" value="0x00"></value>
            <value name="shutter" value="0x01"></value>
            <value name="light" value="0x04"></value>
        </attribute>

From zigpy/zha-device-handlers#2518 (comment)

Edit:

        <attribute id="0x0001" type="enum8" name="Switch type" access="rw" required="o" mfcode="0x1209">
            <value name="undefined" value="0x00"></value>
            <value name="button" value="0x01"></value>
            <value name="key change" value="0x02"></value>
            <value name="switch" value="0x03"></value>
            <value name="switch key change" value="0x04"></value>
        </attribute>

@SwoopX
Copy link
Collaborator Author

SwoopX commented Mar 29, 2024

@Smanar ah, forgot the values. Thanks for poking me, will add them later 👍🏻

@Smanar Smanar mentioned this pull request Apr 1, 2024
1 task
@manup
Copy link
Member

manup commented Apr 2, 2024

Ready to merge? :)

@SwoopX
Copy link
Collaborator Author

SwoopX commented Apr 2, 2024

Ready to merge? :)

I'd say so 🙂

@manup manup merged commit ac793fb into dresden-elektronik:master Apr 3, 2024
2 checks passed
@SwoopX SwoopX deleted the bosch_shutter_control2 branch May 18, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bosch Light/shutter control unit II
3 participants