Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state of Hue lights not always updated correctly #7704

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

ebaauw
Copy link
Collaborator

@ebaauw ebaauw commented Apr 10, 2024

Damn, #7652 is not working as intended. Bloody operator precedence in Javascript.

I missed this during testing, since, apparently, my lights were configured with bindings and attribute reporting for Color Control. Apparently, deCONZ won't remove old bindings no longer defined in the DDF?

@ebaauw ebaauw requested a review from manup April 10, 2024 16:05
@ebaauw ebaauw added Bug report Device Improvement Additional tag to attach to a existing issue. labels Apr 10, 2024
@ebaauw ebaauw added this to the v2.27.0-beta milestone Apr 10, 2024
@manup
Copy link
Member

manup commented Apr 12, 2024

Ha good catch.

deCONZ won't remove old bindings no longer defined in the DDF?

I was thinking about adding this initially since it can be easily done. However I was afraid of breaking some stuff if done without context. However on the todo list is an addition to specify in the DDF that unknown bindings should be removed (default: false as it is now): This way we will be able to control exactly how things are done. Note there are dozens of devices where it can fail since removing bindings does strange things or even impacts groups (Silabs stack based devices are really nasty here).

@woytekbode
Copy link

Just to let you guys know I am currently experiencing improper state updates in my HA + Deconz set-up for my Hue lights.

@manup manup changed the title Bug fix: state of Hue lights not always updated correctly Fix state of Hue lights not always updated correctly Apr 20, 2024
@manup manup merged commit 5bdd6cd into dresden-elektronik:master Apr 20, 2024
@ebaauw ebaauw deleted the huueffects branch April 20, 2024 19:26
@ebaauw ebaauw restored the huueffects branch April 22, 2024 13:03
@ebaauw ebaauw deleted the huueffects branch April 22, 2024 13:04
@manup manup added the Fix label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Device Improvement Additional tag to attach to a existing issue. Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants