Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pairing Profalux roller shutter in legacy code #7735

Merged
merged 3 commits into from
May 2, 2024

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Apr 30, 2024

First PR closed by error #7510


See https://forum.phoscon.de/t/adding-profalux-zigbee-roller-shutters-via-legacy-code/4372

Ok So I m agree this device is "hacky", but without this code no way to support.
It just have no model id and no Manufacture Name, so the legacy code can support it with this hack

        //Add missing values for Profalux device
        if (existDevicesWithVendorCodeForMacPrefix(node->address(), VENDOR_PROFALUX))
        {
            //Shutter ?
            if (i->deviceId() == DEV_ID_ZLL_COLOR_LIGHT)
            {
                lightNode.setManufacturerName(QLatin1String("Profalux"));
                lightNode.setModelId(QLatin1String("PFLX Shutter"));
                lightNode.setNeedSaveDatabase(true);
            }
        }

But this one is disabled whith the recent code.

PS : Profalux have only this device and since years, with same problem, and no support using DDF planned/possible.

de_web_plugin.cpp Outdated Show resolved Hide resolved
@manup manup added the Fix label May 2, 2024
@manup manup changed the title FIX permit the Profalux covering Support. Fix pairing Profalux roller shutter in legacy code May 2, 2024
@manup manup added this to the v2.27.0-beta milestone May 2, 2024
@manup manup merged commit 1ddd316 into dresden-elektronik:master May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants