Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swiss-theme config #2

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Fix swiss-theme config #2

merged 1 commit into from
Nov 11, 2016

Conversation

DirtyF
Copy link
Contributor

@DirtyF DirtyF commented Nov 11, 2016

Fix broccolini/swiss#5 🎉

Happy Jekyllin'!

@dret dret merged commit cf1607d into dret:master Nov 11, 2016
@dret
Copy link
Owner

dret commented Nov 11, 2016

On 2016-11-11 01:42, Frank Taillandier wrote:

Fix broccolini/swiss#5 broccolini/swiss#5 🎉
Happy Jekyllin'!

super duper awesome, thanks! still have to figure out some details such
as making sure that the content is on the start page and not in a post,
but that is more HTML wrangling than a theme struggle. thanks so much!

@DirtyF
Copy link
Contributor Author

DirtyF commented Nov 11, 2016

@dret It's interesting to see how users struggle with gem-based themes, the feature is brand new and needs some improvements.

To override the home layout (or any other theme's file), you have to copy the _layout/home.html from the theme in your repository and tweak it as it suits you.

@dret
Copy link
Owner

dret commented Nov 11, 2016

On 2016-11-11 12:59, Frank Taillandier wrote:

@dret https://github.com/dret It's interesting to see how users
struggle with gem-based themes, the feature is brand new and needs some
improvements.

glad to be your guinea pig! ;-) actually, i am torn with the whole idea.
but i thought this might be the way things go so why not go with it? but
with just one theme (minima) being officially supported by github, this
is not a terrible attractive option.

To override the home layout (or any other theme's file), you have to
copy the _layout/home.html from the theme in your repository and tweak
it as it suits you.

that for example is one part of the gem-based theme setup that i find
pretty bad. that file is hidden very deep in my environment, and first i
have to understand that it's there, then find it, then copy it to the
right place, and then also be aware of the fact that i have now
decoupled this particular aspect of the theme from any further changes.
that feels awfully opaque and brittle to me.

looking at the swiss home.html it strikes my really odd that it simply
has no concept of actually containing content. i realize that this is a
different issue, but anyway, that simply means that the only gem-based
theme i can use that supports content and is supported by github is
minima.

which then means that i have to move away from the gem-based themes and
use one that is part of the repo. which as mentioned above in some ways
feels healthier and more transparent anyway.

thanks for all your help!

@DirtyF
Copy link
Contributor Author

DirtyF commented Nov 11, 2016

that for example is one part of the gem-based theme setup that i find
pretty bad. that file is hidden very deep in my environment, and first i
have to understand that it's there, then find it, then copy it to the
right place, and then also be aware of the fact that i have now
decoupled this particular aspect of the theme from any further changes.
that feels awfully opaque and brittle to me.

FYI Jekyll team plans to add a new command to ease this process in the future, but gem-based themes should still be considered as a beta feature. Until then bundle info and cp are your friends. 🤓

There has been a lot of discussions about gem-based themes being unintuitive to non-developers but I guess the ability to deliver theme mass updates to GitHub Pages users is one of the pursued goals here.

@dret
Copy link
Owner

dret commented Nov 11, 2016

On 2016-11-11 14:40, Frank Taillandier wrote:

FYI Jekyll team plans to add a new command to ease this process in the
future, but gem-based themes should still be as an beta feature. Until
then |bundle info| and |cp| are your friends. 🤓

i am able to find these files, but this process is far from intuitive.
what i would find helpful would be some form of comment in existing
_layouts and _includes directories that would

(a) inform users that these directories are significant and that they
can contain theme-related files, and

(b) maybe even inform users where these files are currently sourced from
(or just link to some resource explaining the whole setup).

There has been a lot of discussions about gem-based themes being
unintuitive to non-developers but I guess the ability to deliver theme
mass updates to GitHub Pages users is one of the pursued goals here.

i see the goals, and of course being able to fix things without
everybody having to pull and potentially even merge from upstream repos
is a big plus. there is just a bit too much magic and opacity for my
taste, but that's just me being more on the old-school side of things.

@DirtyF
Copy link
Contributor Author

DirtyF commented Nov 11, 2016

there is just a bit too much magic and opacity for my taste

@parkr would tell you that too much 🎩 magic is against Jekyll's core principles.

We'll try to make things more explicit.
Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants