Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested changes for switch-exhaustiveness-check #1

Merged
merged 222 commits into from Jan 24, 2020
Merged

Requested changes for switch-exhaustiveness-check #1

merged 222 commits into from Jan 24, 2020

Conversation

cust0dian-old
Copy link
Collaborator

No description provided.

andrewkshim and others added 30 commits September 23, 2019 08:31
…-eslint#1008)

according to the spec, ClassDeclarationBase.id and ClassDeclarationBase.superClass are always present and nullable
@cust0dian-old
Copy link
Collaborator Author

Sorry for the noise changes from the merge of master — I wanted to make it easier to get upstream PR into a mergeable state. You can double-check my additions if you compare my fork to upstream master.

@drets
Copy link
Owner

drets commented Jan 24, 2020

@cust0dian I haven't read the PR super carefully, just surfed it, all looks good to me. Is it ready for merge from your perspective or you want to add something else? If it's ready, I'll just merge it straight away, thank you.

@cust0dian-old
Copy link
Collaborator Author

cust0dian-old commented Jan 24, 2020

@drets yeah, I think it's ready to be merged! Thanks!

Also, if you wish, you can add me as a collaborator for this repo so if there are any comments from the upstream review I can push changes directly here and free you from any work that might arise.

@drets drets merged commit 1f34107 into drets:master Jan 24, 2020
@drets
Copy link
Owner

drets commented Jan 24, 2020

@cust0dian I wish ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet