Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Rector config and code to adhere to the latest rules. #1130

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Jan 12, 2024

  • Added default targets to be files in the current directory, so do not have to specify the path as ..
  • Added code quality checks.
  • Fixed code violations.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a7c4c94) 70.59% compared to head (e88d956) 70.59%.

Files Patch % Lines
...ustom/ys_core/tests/src/Traits/ReflectionTrait.php 0.00% 5 Missing ⚠️
...es/custom/ys_core/tests/src/Traits/AssertTrait.php 0.00% 1 Missing ⚠️
...ules/custom/ys_core/tests/src/Traits/MockTrait.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1130   +/-   ##
========================================
  Coverage    70.59%   70.59%           
========================================
  Files           51       51           
  Lines         3186     3186           
========================================
  Hits          2249     2249           
  Misses         937      937           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk merged commit 78f6c6f into develop Jan 12, 2024
14 of 15 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/update-rector-rules branch February 5, 2024 01:53
@AlexSkrypnyk AlexSkrypnyk added this to the 1.19 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released in 1.19
Development

Successfully merging this pull request may close these issues.

None yet

1 participant