Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Rector config and code to adhere to the latest rules. #1130

Merged
merged 2 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ahoy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ commands:
cmd: |
ahoy cli vendor/bin/phpcs
ahoy cli vendor/bin/phpstan
ahoy cli vendor/bin/rector process --dry-run .
ahoy cli vendor/bin/rector --dry-run
ahoy cli vendor/bin/phpmd . text phpmd.xml

lint-fe:
Expand All @@ -193,8 +193,8 @@ commands:
lint-fix:
usage: Fix lint issues of back-end and front-end code.
cmd: |
ahoy cli vendor/bin/rector process
ahoy cli vendor/bin/phpcbf
ahoy cli vendor/bin/rector process .

test:
usage: Run all tests.
Expand Down
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ jobs:
command: docker compose exec -T cli vendor/bin/phpstan || [ "${DREVOPS_CI_PHPSTAN_IGNORE_FAILURE:-0}" -eq 1 ]
- run:
name: Lint code with Rector
command: docker compose exec -T cli vendor/bin/rector process --dry-run . || [ "${DREVOPS_CI_RECTOR_IGNORE_FAILURE:-0}" -eq 1 ]
command: docker compose exec -T cli vendor/bin/rector --dry-run || [ "${DREVOPS_CI_RECTOR_IGNORE_FAILURE:-0}" -eq 1 ]
- run:
name: Lint code with PHPMD
command: docker compose exec -T cli vendor/bin/phpmd . text phpmd.xml || [ "${DREVOPS_CI_PHPMD_IGNORE_FAILURE:-0}" -eq 1 ]
Expand Down
1 change: 0 additions & 1 deletion .drevops/devtool/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
/.coverage-html
/.phpunit.cache
/cobertura.xml
/composer.lock
/vendor
10 changes: 5 additions & 5 deletions .drevops/devtool/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"mikey179/vfsstream": "^1.6",
"opis/closure": "^3.6",
"helmich/phpunit-json-assert": "^3.5",
"rector/rector": "^0.18.6"
"rector/rector": "^0.19"
},
"autoload": {
"psr-4": {
Expand Down Expand Up @@ -54,11 +54,11 @@
"lint": [
"phpcs",
"phpstan",
"rector process --dry-run ."
"rector --dry-run"
],
"lint:fix": [
"phpcbf",
"rector process . "
"lint-fix": [
"rector",
"phpcbf"
],
"test": "phpunit --no-coverage",
"test:coverage": "XDEBUG_MODE=coverage phpunit"
Expand Down
Loading