Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-124814 #1266

Closed
wants to merge 1 commit into from
Closed

[TS] LPS-124814 #1266

wants to merge 1 commit into from

Conversation

jonathanmccann
Copy link

@jonathanmccann jonathanmccann commented Dec 11, 2020 •
edited

There were a few different ways I saw to resolve this issue so if you think a different direction would be better please let me know.

Most of the formatting logic is taken from https://github.com/liferay/liferay-portal/blob/master/modules/apps/login/login-web/src/main/resources/META-INF/resources/login.jsp#L136-L140

Some notes about the implementation:

  1. The method was deprecated instead of modifying it to avoid a version increase
  2. The date isn't formatted for the log because I thought it would make more sense to have a consistent time zone for the logs
  3. The User object is being passed in to avoid complicated fetching logic in the exception class and needing to fetch the user object twice

Please let me know if there are any questions.

@jonathanmccann
Copy link
Author

ci:test:sf

@jonathanmccann
Copy link
Author

ci:test:relevant

@Sharryxue
Copy link

ci:test:sf

@Sharryxue
Copy link

ci:test:relevant

@Sharryxue
Copy link

Re-trigger the relavent test since the previous seems hang up.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6265d795b50b5e686e73d7e967d8d3283be2e792

Sender Branch:

Branch Name: LPS-124814
Branch GIT ID: f1c019fd9a9bce429701a063bb4b82f73595ea86

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#2880
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:drewbrokke#1266
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - jonathanmccann > drewbrokke - PR#1266 - 2020-12-14[02:17:20]
Spira Jenkins Build:publish-spira-report#10081

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 1 hour 41 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cda3343192c372e26cd7ab875f047991e80c4c2f

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 22478fba589bf9dfa1ff6225fb25ee8fcbb03693

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#3955
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:drewbrokke#1266
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - jonathanmccann > drewbrokke - PR#1266 - 2020-12-14[02:17:36]
Spira Jenkins Build:publish-spira-report#8663

@drewbrokke
Copy link
Owner

See #1272

@drewbrokke drewbrokke closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonathanmccann @Sharryxue @liferay-continuous-integration @drewbrokke