LPS-105910 Update role assignees count to include segments #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hronousDestinationTestRule works.
After LPS-105824, this is the only remaining use of an "ignore" rule in a babelrc file in the repo. "ignore" rules are dangerous because they can lead to untranspiled code making it into IE and breaking things. In this case, we don't even need the configuration because there aren't any "__tests__" directories anywhere in that project.
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Just started reviewing :) |
|
PR sent to brianchandotcom#82178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Drew,
I didn't update RoleLocalServiceImpl directly because SegmentsEntryRoleLS is in module and RoleLS is in core. To keep the changes simple, I just update the count in the JSPs. Let me know if you have other ideas. Thanks!