API refresh #34
Merged
API refresh #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use normal @dataapi classes
Dagger 2.29.1, Kotlin 1.4.10, Retrofit 2.9.0, Moshi 1.10.0, OkHttp 3.14.9, Extra Care 0.3.0, AGP 4.0.1
And rename from :dummy
Renamed from :sso
in package names and class names Replace "Sso" with "SunriseSunsetOrg" in package names and class names
drewhamilton
commented
Sep 26, 2020
calculator/src/main/java/dev/drewhamilton/skylight/calculator/CalculatorSkylight.kt
Outdated
Show resolved
Hide resolved
calculator/src/main/java/dev/drewhamilton/skylight/calculator/CalculatorSkylight.kt
Outdated
Show resolved
Hide resolved
fake/src/test/java/dev/drewhamilton/skylight/fake/dagger/FakeSkylightComponent.kt
Outdated
Show resolved
Hide resolved
skylight/src/test/java/dev/drewhamilton/skylight/FakeSkylight.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert SkylightDay to be Instant-based, avoiding the time zone issues completely. Also ditch its DSL initializer.
Rename "dummy" to "fake" and rename
:ssoto:sunrise-sunset-org.Drop Dagger and JavaX.
Add
isDaytimeextension.