Skip to content

Commit

Permalink
Remove node from the module name.
Browse files Browse the repository at this point in the history
I agree with the npm documentation's rationale:

  This should be a string that identifies your project. Please do not
  use the name to specify that it runs on node, or is in JavaScript.
  You can use the "engines" field to explicitly state the versions of
  node (or whatever else) that your program requires, and it's pretty
  well assumed that it's javascript.

  It does not necessarily need to match your github repository name.

  http://npmjs.org/doc/developers.html#The-package-json-File
  • Loading branch information
drewish committed Apr 22, 2012
1 parent 02513a5 commit fb37a0c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -20,7 +20,7 @@ Install the module with npm:

## Sample Usage

var ex = require('exiv2node');
var ex = require('exiv2');

ex.getImageTags('./photo.jpg', function(err, tags) {
if (err) {
Expand Down
2 changes: 1 addition & 1 deletion exiv2node.cc
Expand Up @@ -189,4 +189,4 @@ void InitAll(Handle<Object> target) {
target->Set(String::NewSymbol("getImageTags"), FunctionTemplate::New(GetImageTags)->GetFunction());
target->Set(String::NewSymbol("setImageTags"), FunctionTemplate::New(SetImageTags)->GetFunction());
}
NODE_MODULE(exiv2node, InitAll)
NODE_MODULE(exiv2, InitAll)
2 changes: 1 addition & 1 deletion test/test.js
@@ -1,4 +1,4 @@
var ex = require('exiv2node');
var ex = require('exiv2');
var assert = require('assert');
var fs = require('fs')

Expand Down
2 changes: 1 addition & 1 deletion wscript
Expand Up @@ -13,6 +13,6 @@ def configure(conf):
def build(bld):
obj = bld.new_task_gen("cxx", "shlib", "node_addon")
obj.cxxflags = ["-g", "-D_FILE_OFFSET_BITS=64", "-D_LARGEFILE_SOURCE", "-Wall"]
obj.target = "exiv2node"
obj.target = "exiv2"
obj.source = "exiv2node.cc"
obj.uselib = "EXIV2"

0 comments on commit fb37a0c

Please sign in to comment.