Address xUnit compiler warnings

drewnoakes · Feb 8, 2018 · f64262f · f64262f
1 parent 0cbead8
commit f64262f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/MetadataExtractor.Tests/Formats/Jpeg/JpegSegmentReaderTest.cs b/MetadataExtractor.Tests/Formats/Jpeg/JpegSegmentReaderTest.cs
@@ -79,8 +79,9 @@ public void ReadSpecificSegments()
         [Fact]
         public void LoadJpegWithoutExifDataReturnsNull()
         {
-            Assert.False(ReadSegments("Data/noExif.jpg")
-                .Any(s => s.Type == JpegSegmentType.App1));
+            Assert.DoesNotContain(
+                ReadSegments("Data/noExif.jpg"),
+                s => s.Type == JpegSegmentType.App1);
         }
 
         [Fact]

diff --git a/MetadataExtractor.Tests/Formats/Png/PngChunkReaderTest.cs b/MetadataExtractor.Tests/Formats/Png/PngChunkReaderTest.cs
@@ -50,15 +50,15 @@ public void Extract_MSPaint()
             Assert.Equal(PngChunkType.IHDR, chunks[0].ChunkType);
             Assert.Equal(13, chunks[0].Bytes.Length);
             Assert.Equal(PngChunkType.sRGB, chunks[1].ChunkType);
-            Assert.Equal(1, chunks[1].Bytes.Length);
+            Assert.Single(chunks[1].Bytes);
             Assert.Equal(PngChunkType.gAMA, chunks[2].ChunkType);
             Assert.Equal(4, chunks[2].Bytes.Length);
             Assert.Equal(PngChunkType.pHYs, chunks[3].ChunkType);
             Assert.Equal(9, chunks[3].Bytes.Length);
             Assert.Equal(PngChunkType.IDAT, chunks[4].ChunkType);
             Assert.Equal(17, chunks[4].Bytes.Length);
             Assert.Equal(PngChunkType.IEND, chunks[5].ChunkType);
-            Assert.Equal(0, chunks[5].Bytes.Length);
+            Assert.Empty(chunks[5].Bytes);
         }
 
         [Fact]
@@ -75,7 +75,7 @@ public void Extract_Photoshop()
             Assert.Equal(PngChunkType.IDAT, chunks[3].ChunkType);
             Assert.Equal(130, chunks[3].Bytes.Length);
             Assert.Equal(PngChunkType.IEND, chunks[4].ChunkType);
-            Assert.Equal(0, chunks[4].Bytes.Length);
+            Assert.Empty(chunks[4].Bytes);
         }
     }
 }
diff --git a/MetadataExtractor.Tests/IO/IndexedReaderTestBase.cs b/MetadataExtractor.Tests/IO/IndexedReaderTestBase.cs
@@ -38,7 +38,7 @@ public abstract class IndexedReaderTestBase
         [Fact]
         public void DefaultEndianness()
         {
-            Assert.Equal(true, CreateReader(new byte[1]).IsMotorolaByteOrder);
+            Assert.True(CreateReader(new byte[1]).IsMotorolaByteOrder);
         }
 
         [Fact]

diff --git a/MetadataExtractor.Tests/IO/SequentialReaderTestBase.cs b/MetadataExtractor.Tests/IO/SequentialReaderTestBase.cs
@@ -40,7 +40,7 @@ public abstract class SequentialReaderTestBase
         [Fact]
         public void DefaultEndianness()
         {
-            Assert.Equal(true, CreateReader(new byte[1]).IsMotorolaByteOrder);
+            Assert.True(CreateReader(new byte[1]).IsMotorolaByteOrder);
         }
 
         [Fact]