Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olympus base Makernotes, CameraSettings, Equipment, and RawDev closer… #210

Merged
merged 6 commits into from
Dec 22, 2016
Merged

Olympus base Makernotes, CameraSettings, Equipment, and RawDev closer… #210

merged 6 commits into from
Dec 22, 2016

Conversation

kwhopper
Copy link
Collaborator

… to dotnet version.

This starts the port from dotnet's Olympus changes to Java. Some changes to the reader and handler were needed to allow some changes to be possible. There will be more coming, but since I'm not a Java guy it would be great if you could make any comments in the PR. I'd like to make sure the formatting and code style of forthcoming PR's are how you want them for Java.

@coveralls
Copy link

coveralls commented Dec 16, 2016

Coverage Status

Coverage decreased (-1.9%) to 35.581% when pulling 85b1871 on kwhopper:olympus_part1_rawdev into db6473e on drewnoakes:master.

@coveralls
Copy link

coveralls commented Dec 17, 2016

Coverage Status

Coverage decreased (-2.3%) to 35.153% when pulling 9390f07 on kwhopper:olympus_part1_rawdev into db6473e on drewnoakes:master.

@coveralls
Copy link

coveralls commented Dec 17, 2016

Coverage Status

Coverage decreased (-2.9%) to 34.574% when pulling 02537da on kwhopper:olympus_part1_rawdev into db6473e on drewnoakes:master.

@coveralls
Copy link

coveralls commented Dec 18, 2016

Coverage Status

Coverage decreased (-3.6%) to 33.924% when pulling a453649 on kwhopper:olympus_part1_rawdev into db6473e on drewnoakes:master.

@kwhopper
Copy link
Collaborator Author

Potentially...

Closes #18
Closes #93
Closes #175

Re-open any of those if there are still issues after testing.

@drewnoakes
Copy link
Owner

Just wanted to say that this looks awesome and I'll merge it asap.

@drewnoakes drewnoakes merged commit 2bc466f into drewnoakes:master Dec 22, 2016
@drewnoakes
Copy link
Owner

Fantastic stuff. Great to see more parity between the implementation outputs.

@kwhopper kwhopper deleted the olympus_part1_rawdev branch December 23, 2016 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants