Refactor TensorMethod #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
drhagen
commented
Dec 29, 2023
drhagen
commented
- Rename PureTensorMethod to TensorMethod
- Base TensorMethod on Problem
- Make tensor method parameters keyword only
- Make most attributes of TensorMethod private
- Make all AST objects fully immutable so that they are hashable
* Rename PureTensorMethod to TensorMethod * Base TensorMethod on Problem * Make tensor method parameters keyword only * Make most attributes of TensorMethod private * Make all AST objects fully immutable so that they are hashable
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 89.02% 89.08% +0.06%
==========================================
Files 54 54
Lines 2951 2960 +9
Branches 526 527 +1
==========================================
+ Hits 2627 2637 +10
+ Misses 248 247 -1
Partials 76 76 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.