-
Notifications
You must be signed in to change notification settings - Fork 302
sourcemaps not working with rc0 #32
Comments
We are definitely aware of this. We are going to be pushing out updates to Thanks, |
Can't debug,I will not use ionic2.rc0 |
Any news on this issue? |
Can confirm. Already running on rc0 and it's a pain :-/ |
Are you saying you're not getting source maps on device? |
No. The maps are wrong, they are not pointing to the source files. Read first comment. |
debug is very import ,can you debug from ts files. |
is there any update on this? the problem is exactly as @rob3c described it on the top. It is possible to enable the generation of sourcemaps for ts->js and for scss->css but both of them are broken! |
srcmaps for ts -> js seem to be fixed thx to #556d2e3 please update version so this is installable via npm =) |
@flobacher this patch works for you? updated app-script, same result but much faster 😄, ok the src folder ist there, but it does not find my templateurl file and under pages only shows the inline Template pages |
That fix is not ready to go yet. We're working on this as I type this, though. Thanks, |
JS sourcemaps have been updated in the latest release. Please pull down the latest and let us know if it fixes your issues, thanks.
|
It is not working for me. Edit: I think it should be: bundle dev started ... Edit2: |
not all ts files are available inside the sourcemap #101 but definitely fast forward, thank you for your good work |
CSS still doesn't work, all I get is the main.css file. |
@ovitrif you can generate srcmaps for sass with a custom sass-conig where you set sourceMap to true. |
We made some additional fixes here, please test:
|
Thanks for the fix. |
Huge THX! Works for me as well! |
I am going to close this issue since it is resolved now. Thanks, |
Pulling app-scripts@latest is not working for me. Using "ionic emulate ios", which does a production build rather than the dev build of "ionic serve". Looking at www/build/main.js.map, it appears broken. The "sources" field should be the list of source files, however it is just the absolute filesystem path to the www/build/main.js file. There's no "sourceContents" field. The map is useless. Oh, and the app fails to load. Can't do an "ionic serve" run to compare, because in dev builds I get a rollup problem, but that's a separate issue - I think. I'm suspicious, because everything worked this morning before pulling app-scripts. |
@TiVoMaker, it might be best to blow away your Thanks, |
Installing app-scripts@latest isn't working for me too. The breakpoints works at first sight but goes crazy after one or two steps. |
See ionic-team/ionic-framework#8292 now. |
SourceMaps are not working fine, @danbucholtz why has been closed? First: Second: Third: Why the team is not testing the changes executing a test and trying to debug in a device? |
concerning broken scss/css sourcemaps see: #46 |
I would like to confirm the issues that @jmesa-sistel is pointing are still occurring (upgraded to the latest The dev setup I am using:
Again, with ionic framework beta breakpoints were working flawlessly using the same setup. What is the right thread to follow this issue? |
I have tested pull request 126 and now I can debug properly. Please merge it for the next version Edit: Edit2: |
To be able to debug on device we need that
Thanks Edit: |
in package.json in scripts section you may have following "scripts": { Change as follows to force generating source map. Strangely production build forces the source-map but dev build (in serve) doesn't use. "ionic:serve": "IONIC_SOURCE_MAP=source-map ionic-app-scripts serve" Once I made the above change I started seeing the typescript files in Chrome debugger. |
You can set a
Thanks, |
For me the problem was that when you're remote debugging on an android device, Chrome debugger cannot access the source map file on the device. The solution/fix is to include the source map inline - see details at #610 |
I originally posted this as a comment (ionic-team/ionic-gulp-tasks#22 (comment)) in an
ionic-gulp-tasks
issue before realizing this is probably a more appropriate repo - oops...Source maps appear broken with the new rc0 setup (I'm using the tabs starter with Crosswalk 2.1.0).
First of all, no form of sourcemaps are enabled by default in the starter project
tsconfig.json
, but that's not strictly anionic-app-scripts
issue. If you set"sourceMap": true
, there will be ultimately two layers of indirection in the source map file references:main.js.map
will point to../../node_modules/
files (which work), as well as../../.tmp/
intermediate.js
files. The side-by-side intermediate.js.map
files do point back to the original../../src
source files and you can see thesourceMappingURL=data:...
comments in the Chrome debugger, but Chrome just ignores those references and only shows the intermediate.js
file sources.Then, if you try to inline the sourcemaps instead via
inlineSourceMap
andinlineSources
in tsconfig as an attempt to bypass any path issues, the inlined source does make it to the intermediate js files (and the same options are mirrored in the generatedtsconfig.tmp.json
file), but the inlined source doesn't make it through to thewww/build
output. There's still only a regularwww/build/main.js.map
file generated without any inlined source :-(The text was updated successfully, but these errors were encountered: