Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IonicPageModule.forChild to accept Array of Pages #11530

Closed
naveedahmed1 opened this issue May 5, 2017 · 4 comments
Closed

Allow IonicPageModule.forChild to accept Array of Pages #11530

naveedahmed1 opened this issue May 5, 2017 · 4 comments

Comments

@naveedahmed1
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[ ] 2.x
[x ] 3.x

I'm submitting a ... (check one with "x")
[ ] bug report
[x ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
Currently for each page we have to create a new NgModule for that page where we have to add IonicPageModule.forChild(MyPage) to imports.

Expected behavior:
What if IonicPageModule.forChild is changed to accepts array of pages. This would allow us to specify multiple pages related to a section to be added to the same NgModule. Like we can do with RouterModule.forChild in Angular 2.

@jgw96
Copy link
Contributor

jgw96 commented May 5, 2017

Hello! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

@jgw96
Copy link
Contributor

jgw96 commented May 5, 2017

This issue was moved to driftyco/ionic-feature-requests#202

@jgw96 jgw96 closed this as completed May 5, 2017
@naveedahmed1
Copy link
Author

Thank you @jgw96 for the update. May be you could just share it with the team working on Lazyloading.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants