Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic Side Menu Content Scrolls While Pulling #2808

Closed
saniyusuf opened this issue Dec 24, 2014 · 8 comments
Closed

Ionic Side Menu Content Scrolls While Pulling #2808

saniyusuf opened this issue Dec 24, 2014 · 8 comments
Assignees
Milestone

Comments

@saniyusuf
Copy link
Contributor

The Ionic Side Menu Content on our app scrolls while it is being pulled. So for example when we are pulling to the the menus of the side menu, the main content is scrollable which should not be. This was notices first on Android 4.4 on a HTC one m8

@drewrygh drewrygh added the menus label Dec 24, 2014
@drewrygh
Copy link
Contributor

Whether the content is scrollable is up to the developer. This shouldn't change when the menu is being dragged open. For example in this codepen I added the attribute scroll=false to ion-content, which fixes the problem you describe.

Is this what you were looking for? If not, can you provide a codepen to help demonstrate the issue?

@drewrygh drewrygh added the needs: reply the issue needs a response from the user label Dec 24, 2014
@saniyusuf
Copy link
Contributor Author

From my understanding scroll = fase is for the ion-content. My ion-content is scrollable but i don't want it to be able to scroll while the side menu is being pulled. This was not a problem with beta 13 but after beta 14 update its a new problem showing up.

@mhartington
Copy link
Member

Hey @saniyusuf, if I understand you correctly, you're talking about as you drag the menu open, you can still scroll?

www.youtube.com/embed/I5RgXIa1VLk

@saniyusuf
Copy link
Contributor Author

Haha Mike you are on point about this. That is exactly what is happening
on beta 14. Why is this

Sani Yusuf
Co Founder / CTO Slapic
@saniyusuf
http://LinkedIn.com/in/saniyusuf
On 31 Dec 2014 17:29, "Mike Hartington" notifications@github.com wrote:

Hey @saniyusuf https://github.com/saniyusuf, if I understand you
correctly, you're talking about as you drag the menu open, you can still
scroll?

www.youtube.com/embed/I5RgXIa1VLk

Reply to this email directly or view it on GitHub
#2808 (comment).

@mhartington
Copy link
Member

Hmm, it may be related to this commit 9f437a8 which fixes #2695

Essentially scroll events would be cancelled if it was within a side-menu.

@7thsonch
Copy link

7thsonch commented Jan 4, 2015

I've got the same problem since beta 14, worked just fine with beta 13.
Even with commit 9f437a8 its still broken.

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Jan 19, 2015
@mhartington
Copy link
Member

Passing this to @perrygovier

@adamdbradley adamdbradley added this to the 1.0.0-rc0 milestone Feb 10, 2015
@kaliagaurav
Copy link

Is this fixed for iOS?

I am using Ionic v1.2.4 and on iPhone I am still getting this issue.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants