Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): fix header bar in modals with top tabs #3347

Merged
merged 1 commit into from
Apr 10, 2015
Merged

fix(css): fix header bar in modals with top tabs #3347

merged 1 commit into from
Apr 10, 2015

Conversation

mikejpeters
Copy link

Fixes #3346

@perrygovier
Copy link
Contributor

@mhartington beat you to it in #3012
Thanks for the PR though!

@mikejpeters
Copy link
Author

This fix is related to an issue specific to modals, which I don't think is fixed in #3012
Please see the codepen in #3346 which uses nightly and is still broken

@mhartington mhartington self-assigned this Mar 30, 2015
@mhartington mhartington reopened this Apr 10, 2015
tlancina added a commit that referenced this pull request Apr 10, 2015
We had a bit of a mixup with #3347
@tlancina tlancina reopened this Apr 10, 2015
tlancina added a commit that referenced this pull request Apr 10, 2015
fix(css): fix header bar in modals with top tabs
@tlancina tlancina merged commit 6f9bd35 into ionic-team:master Apr 10, 2015
@mikejpeters mikejpeters deleted the patch-1 branch April 10, 2015 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Modal header is below tabs-top on iOS Cordova
4 participants