Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Visible During Navigation Transition #8804

Closed
saniyusuf opened this issue Oct 19, 2016 · 17 comments
Closed

Footer Visible During Navigation Transition #8804

saniyusuf opened this issue Oct 19, 2016 · 17 comments

Comments

@saniyusuf
Copy link
Contributor

saniyusuf commented Oct 19, 2016

I have a footer placed in a View I am navigating into. As soon as I start the navigation, the footer in the view being pushed to is seen even before the transition has ended. So you have a case where the footer is seen for some few milliseconds then the body in the header and content is then seen. See URL below for GIF

http://www.giphy.com/gifs/3oriNV1H6FAxdo5co8

Below is my Ionic Infor result.
Your system information:

Cordova CLI: 6.3.1
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v5.10.1
Xcode version: Xcode 7.3 Build version 7D175

@jgw96 jgw96 added the v2 label Oct 20, 2016
@jgw96 jgw96 added this to the 2.0.0-rc.2 milestone Oct 20, 2016
@manucorporat manucorporat self-assigned this Oct 21, 2016
@manucorporat
Copy link
Contributor

Can you share some code to reproduce the issue?

@infinnie
Copy link

The same problem here in iOS mode.

@infinnie
Copy link

@manucorporat I think that the link above to the GIF image illustrated the problem well.

@manucorporat
Copy link
Contributor

Well, there are many issues to be fixed, a lot of them are not real bugs but using the API incorrectly.
I still have to reproduce the issue to fix it, illustrate is not enough.

Some source code to reproduce it will increase the chances to get this solved as soon as possible.

@biesbjerg
Copy link

biesbjerg commented Nov 2, 2016

I'm seeing the same thing after upgrading from beta 11 to rc1.

To reproduce:

Navigate from a page to another page using NavController. Destination page should use this template.

<ion-header>
    <ion-navbar color="brand">
        <ion-title>Footer Transition</ion-title>
    </ion-navbar>
</ion-header>

<ion-content>
    Content
</ion-content>

<ion-footer>
    This is visible during nav.push(Page) transition
    and does not disappear until transition has completed
</ion-footer>

EDIT: I think it's some kind of z-index issue. If I navigate to yet another page, from the page that has a footer, the transition looks okay forward and back. It seems to be a problem only if you navigate "back/up" the component tree, if that makes any sense.

EDIT 2: Is only an issue in iOS mode

@brandyscarney brandyscarney modified the milestone: 2.0.0-rc.2 Nov 4, 2016
@biesbjerg
Copy link

Same issue reported herr: #9121

@joaoveiga
Copy link

Try to wrap your code inside the ion-footer in a ion-toolbar, just like this:

<ion-header>
    <ion-navbar color="brand">
        <ion-title>Footer Transition</ion-title>
    </ion-navbar>
</ion-header>

<ion-content>
    Content
</ion-content>

<ion-footer>
    <ion-toolbar>
        This is visible during nav.push(Page) transition
        and does not disappear until transition has completed
    </ion-toolbar>
</ion-footer>

@manucorporat manucorporat added this to the 2.0.0-rc.5 milestone Dec 9, 2016
@royipressburger
Copy link

@manucorporat I can also see this problem with search bar inside a header. Should I open new task?

@dylanvdmerwe
Copy link
Contributor

Similar issue here #9606

@jgw96
Copy link
Contributor

jgw96 commented Dec 16, 2016

A user has submitted a PR that should fix this issue here #9597 . I will test this PR.

@jgw96
Copy link
Contributor

jgw96 commented Dec 16, 2016

big thanks @lh4111!

@mhartington mhartington reopened this Jan 10, 2017
@brandyscarney brandyscarney modified the milestones: 2.0.0-rc.6, 2.0.0-rc.5 Jan 13, 2017
@adamdbradley adamdbradley modified the milestone: 2.0.0-rc.6 Jan 13, 2017
@Flixt
Copy link

Flixt commented Jan 26, 2017

It seems wrapping things into a <ion-tooblar> is indeed a workaround.
I additionally needed to remove the padding of the <ion-toolbar>

.no-padding {
  padding: 0;
}
<ion-footer>
  <ion-toolbar class="no-padding">
    <!-- animated footer content here -->
  </ion-toolbar>
</ion-footer>

@jgw96
Copy link
Contributor

jgw96 commented Jun 23, 2017

Hello all! After some thought, we are going to close this issue as an ion-footer should always have its contents wrapped in an ion-toolbar. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Jun 23, 2017
@haifzhan
Copy link

still have the issue even ion-toolbar added

@aoe2rtw2
Copy link

Still seeing it even with ion-toolbar as well. Tried removing the padding too but no luck.

@mishanya14228
Copy link

mishanya14228 commented Aug 13, 2018

Adding a div wrapper right after ion-footer tag helped me

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 12, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests