Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC1 swipe-back on iOS doesn't disable vertical scroll #9052

Closed
levymetal opened this issue Nov 5, 2016 · 8 comments
Closed

RC1 swipe-back on iOS doesn't disable vertical scroll #9052

levymetal opened this issue Nov 5, 2016 · 8 comments
Assignees

Comments

@levymetal
Copy link

Short description of the problem:

If you swipe-back on iOS, the content on the current page can still be scrolled. This can be reproduced on both the device and emulator. Video: https://youtu.be/WTS_-KXSW74

What behavior are you expecting?

Once a swipe-back is initiated, vertical scrolling should be disabled.

Steps to reproduce:

  1. Clone the ionic 2 tutorial app
  2. Emulate or run on device
  3. Swipe-back while moving finger up and down, the view can still be scrolled.

Which Ionic Version?

2.0.0-rc.1

Plunker that shows an example of your issue

No need, the tutorial app exhibits this behaviour.

Run ionic info from terminal/cmd prompt:

Your system information:

Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
Ionic App Scripts Version: 0.0.36
ios-deploy version: 1.9.0
ios-sim version: 5.0.9
OS: Mac OS X El Capitan
Node Version: v6.2.1
Xcode version: Xcode 8.1 Build version 8B62

@manucorporat
Copy link
Contributor

manucorporat commented Nov 5, 2016

@levymetal we are aware of this issue, here's the thing, we can't find yet a good way to disable scrolling

@levymetal
Copy link
Author

Ah, I see. Is there a way to disable swipe back then? I've tried <ion-nav [root]="rootPage" swipeBackEnabled="false"></ion-nav>, and putting swipeBackEnabled = false pretty much everywhere but nothing seems to work.

@manucorporat manucorporat self-assigned this Nov 6, 2016
@danielcrk-cn
Copy link

@levymetal Yes, have a look here:
http://ionicframework.com/docs/v2/api/config/Config/

I'm concidering wring my own "swipe to go back" using the swipe gesture event and manually poping the page from the navstack. It won't be as nice at the native "real time swipe" of course, but better than nothing, and better that the current ionic implementation. Might be worth a try!

@levymetal
Copy link
Author

@danielcrk-cn Awesome, that worked, cheers for that! I like your idea as a stop-gap until this issue is resolved. Let us know if you end up doing it.

@biesbjerg
Copy link

biesbjerg commented Nov 18, 2016

This is not fixed in RC3 (at least not in my app).

2016-11-18 01_57_09

I see some logging in XCode console regarding scrolling, but I'm still able to scroll the leaving view in the middle of a swipe back.

2016-11-18 01:41:34.562718 Mindly[4939:1396787] App Root: Scroll Disable Assist true
2016-11-18 01:41:35.866311 Mindly[4939:1396787] App Root: Scroll Disable Assist false

Everything should be up to date:

Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.3
Ionic CLI Version: 2.1.12
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.45
ios-deploy version: 1.9.0
ios-sim version: 5.0.11
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.1 Build version 8B62

@manucorporat
Copy link
Contributor

@biesbjerg it need hybrid assistance, are you using the latest ionic WK plugin?

@RikdeVos
Copy link

RikdeVos commented Mar 1, 2017

Any updates regarding issue? I have not yet found a method to disable the scrolling during swipe back.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants