Added custom attribute data-instantActivate #2394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… delay when an element is touched (down to 1ms)
|
Can you make the changes in the correct file? https://github.com/driftyco/ionic/blob/master/js/utils/activator.js |
… delay when an element is touched (down to 1ms)
|
Oh sorry, done |
|
Awesome, I'll let @adamdbradley or @perrygovier look this over |
|
Any news regarding this? |
|
+1! |
1 similar comment
|
+1! |
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
|
Updates have been made to the nightly builds to improve visual feedback. Closing this PR because the new system checks if its actively scrolling or not, which was the 80ms delay's intent. |
|
It's commit d1c92da for anyone wondering. |
|
thanks 2014-12-07 23:13 GMT+02:00 PureSpider notifications@github.com:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom attribute data-instantActivate to remove 80ms activation delay when an element is touched (down to 1ms)
Forum thread here http://forum.ionicframework.com/t/no-visual-feedback-on-quick-taps/7280/10