Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): set correct title bar height #4965

Merged
merged 1 commit into from
May 10, 2016
Merged

fix(bar): set correct title bar height #4965

merged 1 commit into from
May 10, 2016

Conversation

5im0n
Copy link
Contributor

@5im0n 5im0n commented Jan 14, 2016

When you customize the SASS variables: $bar-footer-height, $bar-subheader-height, $bar-subfooter-height. If you set a title inside subheader, footer, and subfooter bar:

      <ion-header-bar class="bar-stable">
        <h1 class="title">Header</h1>
      </ion-header-bar>

      <ion-header-bar class="bar-subheader bar-energized">
        <h1 class="title">SubHeader</h1>
      </ion-header-bar>

      <ion-footer-bar class="bar-stable">
        <h1 class="title">Footer</h1>
      </ion-footer-bar>

      <ion-footer-bar class="bar-energized bar-subfooter">
        <h1 class="title">SubFooter</h1>
      </ion-footer-bar>

The title have a wrong height!

ScreenShot to illustrate the problem:
capture

@5im0n
Copy link
Contributor Author

5im0n commented Jan 14, 2016

Related issue #4966

@5im0n 5im0n mentioned this pull request Apr 20, 2016
@danbucholtz
Copy link
Contributor

This looks good to me. Nice work, @5im0n. Thanks for contributing to Ionic!

@danbucholtz danbucholtz merged commit 6a5e6bc into ionic-team:master May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants