-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bioc release version bumps and GitHub Actions update #138
Conversation
I think the GHA check error is still due to |
thanks for this @lmweber |
Ok this should be fixed now! @drighelli @HelenaLC could you please approve and then we can merge these version bumps. Thank you! |
Hey, just bumping this. Could you please approve @drighelli or @HelenaLC ? Then we can merge these version bumps into our GitHub branches (so we don't end up with any merge conflicts during later work). Thank you! |
Hi @lmweber I already reviewed the updates, I was just asking why aren't we considering other platforms in the GHA |
Hey, I commented those out because sometimes we had errors for Windows/Mac in the GHA builds but not in the Bioconductor builds. So it was easier to remove those, since in the end only the Bioconductor builds matter for users (although the GHA builds are definitely useful for us as developers as a pre-check before pushing to Bioconductor). I think this is resolved now though, so I'll try uncommenting them again. Thanks! |
Cool, looks like it worked. If this looks ok for you could you please click approve, and I'll merge / sync all our branches / remotes. Thank you! |
.github/workflows/check-bioc.yml
Outdated
- { os: windows-latest, r: 'devel', bioc: '3.17'} | ||
- { os: ubuntu-latest, r: '4.3', bioc: '3.17', cont: "bioconductor/bioconductor_docker:RELEASE_3_17", rspm: "https://packagemanager.rstudio.com/cran/__linux__/jammy/latest" } | ||
#- { os: macOS-latest, r: '4.3', bioc: '3.17'} | ||
#- { os: windows-latest, r: '4.3', bioc: '3.17'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmweber why are osx and windows commented?
Are they still in some process update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't see this comment earlier, sorry! I never know where to find the review comments in GitHub. Thanks for approving now!
Thank you @lmweber ! |
Hi, this PR is for: