Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read multiple configs from directory #5

Closed
sysmonk opened this issue Jun 27, 2014 · 5 comments
Closed

read multiple configs from directory #5

sysmonk opened this issue Jun 27, 2014 · 5 comments

Comments

@sysmonk
Copy link
Contributor

sysmonk commented Jun 27, 2014

Hi,

Any plans to pull this over to log-courier - elastic/logstash-forwarder#136 ?
Would be great to have ability to load multiple config files based on the server roles.

@driskell
Copy link
Owner

It's one of the things I want to do, yes. I think there was a PR there but I wasn't sure on its approach.

I was thinking of having a "configs" as well as "files" or something, which lists a set of config files to load. And those config files would simply be JSON arrays (like "files" is) which are added in. I think the PR I saw was merging in "network" too and I didn't think that was straight forward.

If that's around what you are thinking it's on the roadmap.

Jason

@sysmonk
Copy link
Contributor Author

sysmonk commented Jun 27, 2014

If you mean that you plan to add something like "configs": [ { "paths": [ "/etc/log-courier.d/*.conf" ] } ] then that's great, but if we need to list all the configs separately - then not really what i want :)

@driskell
Copy link
Owner

Yeh nobody would want that :-P

It would be like:

"file_configs": [ "/etc/log-courier/conf.d/*.conf" ]

Glob support of course.

driskell added a commit that referenced this issue Jun 29, 2014
@driskell
Copy link
Owner

I read through elastic/logstash-forwarder#136
I looked at elastic/logstash-forwarder#154 too but I tried a different approach I thought would be better. That is to have a main config file and these additional files just for files configuration and not network.

I got it in while on the train and works pretty good. Feedback welcome :)

Instructions here:
https://github.com/driskell/log-courier/blob/stable/docs/Configuration.md#includes

@sysmonk
Copy link
Contributor Author

sysmonk commented Jun 30, 2014

Thanks, looks to be working great!

@sysmonk sysmonk closed this as completed Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants