Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pickling of CloudPath #224

Merged
merged 2 commits into from
May 16, 2022
Merged

Enable pickling of CloudPath #224

merged 2 commits into from
May 16, 2022

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented May 13, 2022

Implement __getstate__ and __setstate__ for CloudPath objects.

Use the default client for the class on unpickling.

closes #223

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2022

@pjbull pjbull requested a review from jayqi May 13, 2022 06:05
@codecov-commenter
Copy link

Codecov Report

Merging #224 (b955223) into master (7e0de25) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #224   +/-   ##
======================================
  Coverage    94.7%   94.8%           
======================================
  Files          21      21           
  Lines        1248    1256    +8     
======================================
+ Hits         1183    1191    +8     
  Misses         65      65           
Impacted Files Coverage Δ
cloudpathlib/azure/azblobclient.py 94.6% <100.0%> (ø)
cloudpathlib/cloudpath.py 93.2% <100.0%> (+0.1%) ⬆️

Copy link
Member

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@pjbull pjbull merged commit 85268c8 into master May 16, 2022
@pjbull pjbull deleted the 223-pickle-time branch May 16, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot pickle path objects
3 participants