Skip to content

Enable pickling of CloudPath - #224

Merged
pjbull merged 2 commits into
masterfrom
223-pickle-time
May 16, 2022
Merged

pjbull merged 2 commits into
masterfrom
223-pickle-time

Conversation

@pjbull

@pjbull pjbull commented May 13, 2022

Copy link
Copy Markdown
Member

Implement __getstate__ and __setstate__ for CloudPath objects.

Use the default client for the class on unpickling.

closes #223

@github-actions

github-actions Bot commented May 13, 2022

Copy link
Copy Markdown
Contributor

@pjbull
pjbull requested a review from jayqi May 13, 2022 06:05
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #224 (b955223) into master (7e0de25) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #224   +/-   ##
======================================
  Coverage    94.7%   94.8%           
======================================
  Files          21      21           
  Lines        1248    1256    +8     
======================================
+ Hits         1183    1191    +8     
  Misses         65      65           
Impacted Files Coverage Δ
cloudpathlib/azure/azblobclient.py 94.6% <100.0%> (ø)
cloudpathlib/cloudpath.py 93.2% <100.0%> (+0.1%) ⬆️

@pjbull
pjbull force-pushed the 223-pickle-time branch from b955223 to 683a377 Compare May 16, 2022 05:32

@jayqi jayqi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@pjbull
pjbull merged commit 85268c8 into master May 16, 2022
@pjbull
pjbull deleted the 223-pickle-time branch May 16, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot pickle path objects

3 participants