Move _handle attribute up in CloudPath __init__

[bryanwweber]

The _handle attribute needs to be set before any code can raise an exception. This is because if something tries to call del after the exception as the process is exiting, _handle must be set to avoid an AttributeError in del.

Resolves #299.

[pjbull]

Thanks @bryanwweber—looks like you need to run black to format those lines (you can use make format on your local branch).

[bryanwweber]

Thanks @pjbull! Fixed now 😄 That's what I get for trying to make the change on the Web interface 😝

[codecov-commenter]

Codecov Report

Merging #300 (9a397a6) into master (31f93ac) will decrease coverage by 0.3%.
The diff coverage is 100.0%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #300     +/-   ##
========================================
- Coverage    94.9%   94.5%   -0.4%     
========================================
  Files          21      21             
  Lines        1341    1341             
========================================
- Hits         1273    1268      -5     
- Misses         68      73      +5     

Impacted Files	Coverage Δ
cloudpathlib/cloudpath.py	93.7% <100.0%> (ø)
cloudpathlib/s3/s3client.py	92.9% <0.0%> (-2.7%)	⬇️
cloudpathlib/gs/gsclient.py	92.8% <0.0%> (-1.8%)	⬇️

[pjbull]

Thanks @bryanwweber! I'll merge this in to a repo-local branch so we can run the live tests.

[bryanwweber]

Thanks! Do I need to do anything else?

[pjbull]

Nope, once tests pass in #301 I'll merge it in! It'll be in the next release, thanks!

[bryanwweber]

Great thank you for the quick responses!