Local PR for #300 #301
Merged
Local PR for #300 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move _handle attribute up in CloudPath __init__ The _handle attribute needs to be set before any code can raise an exception. This is because if something tries to call __del__ after the exception as the process is exiting, _handle must be set to avoid an AttributeError in __del__. Resolves #299. * Formatting Co-authored-by: Bryan Weber <bweber@rebelliondefense.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
======================================
Coverage 94.9% 94.9%
======================================
Files 21 21
Lines 1341 1341
======================================
Hits 1273 1273
Misses 68 68
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _handle attribute needs to be set before any code can raise an exception. This is because if something tries to call del after the exception as the process is exiting, _handle must be set to avoid an AttributeError in del.
Resolves #299.
Co-authored-by: Bryan Weber bweber@rebelliondefense.com