Implement fine-grained file cache control options#314
Merged
Conversation
Contributor
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
========================================
- Coverage 94.2% 94.1% -0.2%
========================================
Files 21 22 +1
Lines 1396 1461 +65
========================================
+ Hits 1316 1375 +59
- Misses 80 86 +6
|
jayqi
requested changes
Feb 2, 2023
Member
jayqi
left a comment
There was a problem hiding this comment.
This looks awesome! Will be a great new feature.
I saw a bunch of typos in the caching notebook—wondering if we should nbautoexport it for PR review purposes.
3c9fe99 to
bac8e73
Compare
Member
Author
jayqi
requested changes
Feb 7, 2023
Member
Author
|
Thanks @jayqi! I incorporated all your suggestions |
jayqi
approved these changes
Feb 8, 2023
Member
jayqi
left a comment
There was a problem hiding this comment.
One remaining typo. LGTM otherwise!
Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements fine-grained controls for file cache clearing.
Best overview is the update to caching.ipynb, which you can see in the docs preview:
https://deploy-preview-314--gallant-agnesi-5f7bb3.netlify.app/caching/#clearing-the-file-cache
Probably worth it to start with reading the docs since we want those to be a clear explanation of the change.
Bonus:
.close()was called twice, the file would upload twice). This usually resulted in a failure to overwrite because modified times were the same. Fixed to not upload ifclosehas already been called.Closes #10