Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live tests for #362 #363

Merged
merged 1 commit into from Sep 14, 2023
Merged

Live tests for #362 #363

merged 1 commit into from Sep 14, 2023

Conversation

pjbull
Copy link
Member

@pjbull pjbull commented Sep 14, 2023

  • Update write_text to include newline variable

  • Remove old docstring link

  • Update cloudpathlib/cloudpath.py with black correction

  • Remove use of io module

  • update HISTORY.md

* Update write_text to include newline variable

* Remove old docstring link

* Update cloudpathlib/cloudpath.py with black correction

* Remove use of io module

* update HISTORY.md
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request September 14, 2023 16:32 Inactive
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #363 (7c4066b) into master (d2079cc) will decrease coverage by 0.2%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #363     +/-   ##
========================================
- Coverage    93.9%   93.7%   -0.2%     
========================================
  Files          22      22             
  Lines        1512    1512             
========================================
- Hits         1420    1418      -2     
- Misses         92      94      +2     
Files Changed Coverage Δ
cloudpathlib/cloudpath.py 91.9% <100.0%> (-0.4%) ⬇️

@pjbull pjbull merged commit e6ae9fa into master Sep 14, 2023
25 checks passed
@pjbull pjbull deleted the 362-live-tests branch September 14, 2023 16:56
@pjbull
Copy link
Member Author

pjbull commented Sep 14, 2023

Merged into the main branch, thanks @pricemg!

msmitherdc added a commit to CRREL/cloudpathlib that referenced this pull request Nov 1, 2023
* Add "CloudPath" to possible cloud_path types (drivendataorg#342) (drivendataorg#343)

* Add "CloudPath" to possible cloud_path types (drivendataorg#342)

* Add to changelog

---------

Co-authored-by: Karol Zlot <11590960+karolzlot@users.noreply.github.com>

* Added with_stem support (drivendataorg#290) (drivendataorg#354)

* Added with_stem support

* Update readme (+small fix to make_support_table)

* Added test

* Update history.md

* Fallback to trivial CPython implementation if `with_stem` is not available

* Add a clarification comment

Co-authored-by: Daniel Oriyan <gilthans@gmail.com>

* Fix flake8 errors (drivendataorg#359)

* Fix flake8 errors

* Fix wrong comparison

* Bump codecov action version; add codecov token

---------

Co-authored-by: Jay Qi <jayqi@users.noreply.github.com>

* Update write_text to include newline variable (drivendataorg#362) (drivendataorg#363)

* Update write_text to include newline variable

* Remove old docstring link

* Update cloudpathlib/cloudpath.py with black correction

* Remove use of io module

* update HISTORY.md

Co-authored-by: Matthew Price <matthew.price23@gmail.com>

* Add support for Python 3.12 (drivendataorg#364)

* passing tests

* remove print

* make method signatures match

* Remove unused import

* ignore type errors

* ignore more type errors

* make linting and tests work on multiple py versions

* add 3.12 to CI and pyproject

* use pytest-cases fork

* More performant walk implementation

* format

* update methods

* Test walk method

* Version agnostic tests

* update tests

* Add tests

* Order agnostic walk test

* Changes

* Update changelog

* sleep for flaky test

* Sleep flaky tests

* sleepier

* implement env var for local cache dir (drivendataorg#361)

* Add contributing guidelines (drivendataorg#367)

* contributing guidelines

* Apply suggestions from code review

Co-authored-by: Katie Wetstone <46792169+klwetstone@users.noreply.github.com>

* WIP

* Contrib tweaks and PR template

* clarification

* update history typo

---------

Co-authored-by: Katie Wetstone <46792169+klwetstone@users.noreply.github.com>

* Version bump

* format with black

* ignore type checking here

* update client reference

* update

* no need to change

---------

Co-authored-by: Peter Bull <pjbull@gmail.com>
Co-authored-by: Karol Zlot <11590960+karolzlot@users.noreply.github.com>
Co-authored-by: Daniel Oriyan <gilthans@gmail.com>
Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com>
Co-authored-by: Jay Qi <jayqi@users.noreply.github.com>
Co-authored-by: Matthew Price <matthew.price23@gmail.com>
Co-authored-by: Peter Bull <peter@drivendata.org>
Co-authored-by: Katie Wetstone <46792169+klwetstone@users.noreply.github.com>
Co-authored-by: Michael D. Smith <michael.smith@erdc.dren.mil>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants