Defend from AttributeErrors in CloudPath.__del__ #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the CloudPath Client instance is incomplete, it may not have a file_cache_mode attribute. Using getattr defensively prevents the AttributeError from causing __del__ to exit early.
pjbull
requested changes
Apr 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
========================================
- Coverage 93.8% 93.4% -0.4%
========================================
Files 23 23
Lines 1643 1644 +1
========================================
- Hits 1542 1537 -5
- Misses 101 107 +6
|
jayqi
reviewed
Apr 1, 2024
jayqi
approved these changes
Apr 1, 2024
|
Thank you, and thank you for addressing the nit |
jayqi
added a commit
that referenced
this pull request
Apr 1, 2024
* Defend from AttributeErrors in CloudPath.__del__ If the CloudPath Client instance is incomplete, it may not have a file_cache_mode attribute. Using getattr defensively prevents the AttributeError from causing __del__ to exit early. * Update HISTORY * Fix tests by fixing a copy-paste mistake * Use None instead of object as dummy client. --------- Co-authored-by: Bryan Weber <bryan.w.weber@gmail.com> Co-authored-by: Jay Qi <jayqi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CloudPath Client instance is incomplete, it may not have a file_cache_mode attribute. Using getattr defensively prevents the AttributeError from causing del to exit early.
Closes #372
Contributor checklist:
CONTRIBUTING.mdCloses #issueappears in the PR summary (e.g.,Closes #123).HISTORY.mdwith the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.