Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Use git-lfs for test images #17

Closed
2 tasks
pjbull opened this issue Aug 4, 2017 · 4 comments
Closed
2 tasks

Use git-lfs for test images #17

pjbull opened this issue Aug 4, 2017 · 4 comments

Comments

@pjbull
Copy link
Member

pjbull commented Aug 4, 2017

Overview

Currently test images are stored in the git repository. These files won't change much so we should try to save bandwidth and separate concerns by tracking them with git-lfs instead.

Expected Behavior

DICOM images in tests/assets are managed with git-lfs

Acceptance criteria

  • test images are managed by git-lfs
  • large image files are removed from the repository

NOTE: All PRs must follow the standard PR checklist.

@poppingtonic
Copy link

I have a public fork here and want to tackle this issue. I can't update my fork with the LFS data because of this issue

Git LFS: (0 of 534 files) 0 B / 268.10 MB                                                                                                              
batch response: @poppingtonic can not upload new objects to public fork poppingtonic/concept-to-clinic                                                 
batch response: @poppingtonic can not upload new objects to public fork poppingtonic/concept-to-clinic                                                 
batch response: @poppingtonic can not upload new objects to public fork poppingtonic/concept-to-clinic                                                 
batch response: @poppingtonic can not upload new objects to public fork poppingtonic/concept-to-clinic                                                 
batch response: @poppingtonic can not upload new objects to public fork poppingtonic/concept-to-clinic                                                 
batch response: @poppingtonic can not upload new objects to public fork poppingtonic/concept-to-clinic  

@lamby
Copy link
Contributor

lamby commented Aug 10, 2017

@poppingtonic Hey, thanks for jumping in :) I think what would be the best "next step" would be if you could get a branch / PR up and running here - that way it should smooth the permissions out, no?

@lamby lamby closed this as completed in 7d46f08 Aug 14, 2017
@lamby
Copy link
Contributor

lamby commented Aug 14, 2017

@poppingtonic Thanks so much for this. As we can't work around the permissions I've gone ahead and done this in 7d46f08 and will credit you for the effort :)

@poppingtonic
Copy link

Thank you @lamby.

musale pushed a commit to musale/concept-to-clinic that referenced this issue Aug 31, 2017
Add make command to generate html files

Add docker services for document generation

Add dependencies for sphinx in prediction reqs

This is because I build the documentation container from the prediction
development Dockerfile.

Make command to run tests on documentation service

Add documentation table of content

Restart document compiling always

Add how to edit this documentation file

Add testing of the docs and more instructions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants