Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Rethink docker-compose container dependencies #216

Open
4 tasks
reubano opened this issue Nov 8, 2017 · 4 comments
Open
4 tasks

Rethink docker-compose container dependencies #216

reubano opened this issue Nov 8, 2017 · 4 comments

Comments

@reubano
Copy link
Contributor

reubano commented Nov 8, 2017

Overview

As a follow-up to #199, we may need to re-evaluate the container structure. Currently, all services benefit from the caching, but only the docs service benefits from the added python requirements. Both the interface and prediction services wind up bloated with extra requirements they don't need.

Expected Behavior

The docs service should use caches provided by the interface and prediction services. However, neither the interface nor prediction services should have unnecessary python requirements.

Technical details

Acceptance criteria

  • when running docker-compose -f local.yml build on a clean system, the python requirements files should not be downloaded by documentation service.
  • when running docker-compose -f local.yml build on a clean system, the documentation service should use the caches provided by the prediction and interface services.
  • when running docker-compose -f local.yml build on a clean system, the prediction service should not install unnecessary interface python requirements such as Django.
  • when running docker-compose -f local.yml build on a clean system, the interface service should not install unnecessary prediction python requirements such as pytorch.

NOTE: All PRs must follow the standard PR checklist.

@WGierke
Copy link
Contributor

WGierke commented Nov 8, 2017

I guess the docs service should still use the cache that was built by the interface service (instead of re-downloading all the Python dependencies)? Do you have any ideas how to accomplish that?

@reubano
Copy link
Contributor Author

reubano commented Nov 8, 2017

@WGierke so after thinking about this some more, we may need to re-evaluate the entire structure. Currently, all services benefit from the caching, but only the docs service benefits from the added python requirements. Both the interface and prediction services wind up bloated with extra requirements they don't need.

And I'm not sure if it's possible to satisfy both optimizations at once.

@reubano reubano changed the title Invert docker-compose interface service dependency Rethink docker-compose dependencies Nov 8, 2017
@reubano reubano changed the title Rethink docker-compose dependencies Rethink docker-compose container dependencies Nov 8, 2017
@isms
Copy link
Contributor

isms commented Dec 4, 2017

@reubano Is there something specific we can change this issue to? As currently posed it seems overly broad and not actionable.

@reubano
Copy link
Contributor Author

reubano commented Dec 6, 2017

@isms still thinking this over... is there anything in particular that is too broad/not well explained? cc @pjbull

@isms isms modified the milestones: 2-feature-building, 3-packaging Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants