Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

#159 Docker: Reuse Caches #199

Merged
merged 3 commits into from
Nov 3, 2017

Conversation

WGierke
Copy link
Contributor

@WGierke WGierke commented Nov 2, 2017

First, a base image is built that installs all needed pip requirements. The docker containers, that need parts of the requirements (prediction, interface and documentation services), then are built on top of that base image. Thus, building the documentation service doesn't require to install all pip requirements again resulting in a great speed-up of the container building.

Reference to official issue

This addresses #159

How Has This Been Tested?

docker-compose -f local.yml build && docker-compose -f local.yml up builds all containers properly and fires them up.

CLA

  • I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

PS: Accelerated the build time on Travis from μ=23.5min ± 2.2 min (measured on the last 25 builds) to 18 min (first successful build of this branch) 🎉 The time it takes to build the services locally should thus also greatly be decreased.

@lamby
Copy link
Contributor

lamby commented Nov 3, 2017

building the documentation service doesn't require to install all pip requirements again

As someone who accidentally needed to remake these images yesterday on a terrible internet connection, oh my gosh thank you ♥

@lamby lamby merged commit 9c58823 into drivendataorg:master Nov 3, 2017
@reubano reubano mentioned this pull request Nov 15, 2017
2 tasks
@reubano reubano mentioned this pull request Nov 28, 2017
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants