Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

#161 Remove pycache directories files on build #209

Merged
merged 1 commit into from Nov 6, 2017

Conversation

rahit
Copy link
Contributor

@rahit rahit commented Nov 3, 2017

Remove all pycache files when you run docker-compose -f local.yml build prediction.

Description

Added a one-line code in Docker file referenced at #161 by @reubano

Reference to official issue

fixes #161

Motivation and Context

Old pycache files can interfere with proper running of docker-compose -f local.yml build and may even cause the following error:

import file mismatch:
imported module 'app.src.tests.test_load_ct' has this __file__ attribute:
  /Volumes/Nahla/alcf/prediction/src/tests/test_load_ct.py
which is not the same as the test file we want to collect:
  /app/src/tests/test_load_ct.py

There should be a convenient script that can be run to remove all pycache files.

How Has This Been Tested?

Run build several times without any error.

CLA

  • I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

@@ -1,3 +1,3 @@
FROM concepttoclinic_base

WORKDIR /app
WORKDIR /app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care not to make unnecessary changes - makes it harder to review!

@lamby
Copy link
Contributor

lamby commented Nov 4, 2017

LGTM, but I'm seeing 18 commits on this pull request. Can you rebase? :)

@lamby lamby changed the title #161 remove pycache onbuild #161 Remove pycache directories files on build Nov 4, 2017
@rahit
Copy link
Contributor Author

rahit commented Nov 5, 2017

@lamby done

@lamby lamby merged commit 092b83b into drivendataorg:master Nov 6, 2017
@lamby
Copy link
Contributor

lamby commented Nov 6, 2017

merged, many thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create __pycache__ removal script
2 participants