New API endpoint to fetch dataset directory #81
Conversation
.gitignore
Outdated
| # ignore Sphinx apidoc | ||
| _apidoc_* | ||
| _apidoc_* |
interface/backend/api/urls.py
Outdated
| @@ -9,6 +9,7 @@ | |||
| CandidateViewSet, | |||
| NoduleViewSet, | |||
| ImageSeriesViewSet, | |||
| ImageSrcApiView | |||
There was a problem hiding this comment.
Please add a trailing comma to avoid VCS noise for the next addition! :)
|
Hey, thanks for this! Please rebase and — whilst you're at it — address those tiny niggling things I brought up :) |
|
@lamby Resolved conflicts and modified as per your suggestion. I have mistakenly used master of forked repo for the pull request. I will do it in new branch for future changes. :) |
.gitignore
Outdated
|
|
||
|
|
||
| # ignore Sphinx apidoc | ||
| _apidoc_* |
There was a problem hiding this comment.
Please revert this change - see #80 (in particular https://github.com/concept-to-clinic/concept-to-clinic/pull/80/files)
interface/backend/api/urls.py
Outdated
| @@ -9,6 +9,7 @@ | |||
| CandidateViewSet, | |||
| NoduleViewSet, | |||
| ImageSeriesViewSet, | |||
| ImageSrcApiView, | |||
There was a problem hiding this comment.
Can we change this to ImageAvailableApiView or something more descriptive?
interface/backend/api/urls.py
Outdated
| @@ -19,5 +20,6 @@ | |||
|
|
|||
| urlpatterns = [ | |||
| url(r'^', include(router.urls)), | |||
| url(r'^image_src/$', ImageSrcApiView.as_view()), | |||
There was a problem hiding this comment.
As above, how about ^images/available$?
interface/backend/api/views.py
Outdated
| """ | ||
| Return a list of files and folders in dataset | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Are you planning to implement or leave this stubbed out? Stub is acceptable if that's the plan, we'll just create another issue for actually implement this.
There was a problem hiding this comment.
We can create a new issue for this.
|
Hi @rahit |
|
Thank you @lamby for the suggestions. I have not get the chance to work on the modifications yet. I would like to let you know that your feedback is clear to me and I will get back asap. |
Brilliant stuff, looking forward to it :) |
interface/frontend/index.html
Outdated
| @@ -100,8 +100,8 @@ <h3 class="card-title">{{ selected.patient_id }}</h3> | |||
| methods: { | |||
| fetchData: function() { | |||
| var vm = this; | |||
| this.$http.get('/api/images/').then( | |||
| function(response) { | |||
| this.$http.get('/api/images/available').then( | |||
There was a problem hiding this comment.
Hm, I think this should use {% url … %} ?
There was a problem hiding this comment.
Whole <script> is under {% verbatim %}. Even if verbatim is omitted from script section, is it possible to use {% url %} inside Vue ?
interface/backend/api/views.py
Outdated
| """ | ||
| Return a list of files and folders in dataset | ||
| """ | ||
| pass |
There was a problem hiding this comment.
For now, should this return at least some kind of empty result? :)
rahit
force-pushed
the
master
branch
2 times, most recently
from
f2fc786
to
ed3e55f
Compare
|
Hey all, who is this blocking on? Whilst we are assigned to @rahit here, that may not be accurate AFICT; please update if this is wrong! — lamby |
|
@lamby let me know if there is anything that should be done for this pull request. |
|
@rahit Can you rebase against master; currently conflicting there :) |
|
@lamby done |
|
Thanks, merged @rahit |
New API for direcotory listing in homepage as described in #77
Description
Introducing new API endpoint which will be used to retrieve images from data directory.
Reference to official issue
See issue #77
How Has This Been Tested?
This modification will effect homepage initial dataload. Implementation of the API is yet to be made.
Updates of Acceptance Criteria
CLA