Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existing config and don't process if not new #16

Closed
2 tasks
pjbull opened this issue May 2, 2020 · 1 comment · Fixed by #24
Closed
2 tasks

Check for existing config and don't process if not new #16

pjbull opened this issue May 2, 2020 · 1 comment · Fixed by #24

Comments

@pjbull
Copy link
Member

pjbull commented May 2, 2020

If we change the command, you could end up with multiple versions in your config file.

https://github.com/drivendataorg/nbautoexport/blob/master/nbautoexport/nbautoexport.py#L97-L103

  • We should include the version number in the command initialize so that we can compare
  • If the installing version number > one in config, we should remove that version and replace with the new one.
@jayqi
Copy link
Member

jayqi commented Jun 6, 2020

The above link doesn't make sense anymore, since the lines have since moved around. Here is a permalink to the correct source code:

command = """# >>> nbautoexport initialize >>>
try:
from nbautoexport import post_save
c.FileContentsManager.post_save_hook = post_save
except:
pass
# <<< nbautoexport initialize <<<"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants