-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Awareness #24
Conversation
8e2342e
to
a2eb571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
else: | ||
c.FileContentsManager.post_save_hook = post_save | ||
except: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this method is getting more complicated, let's see if there's a good way to store this block as Python code so it gets highlighting in source control and could be easier to test directly if we need to eventually. I think that we could either define the function and use inspect.getsource
to get this code after the function is imported, or maybe just have it in a .py
that we read instead of importing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to check -- looks great!
@@ -209,6 +255,9 @@ def install( | |||
verbose: bool = typer.Option( | |||
False, "--verbose", "-v", is_flag=True, show_default=True, help="Verbose mode" | |||
), | |||
version: bool = typer.Option( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kewl
@r-b-g-b ready for re-review. |
25578b7
to
14d98ff
Compare
--version
flag to CLI. I copied this example from the Typer docs.nbautoexport/
, excluding_version.py
from versioneer. This looks like: